Reapply "Prefer calloc over of malloc+zeroMemory. NFC"
#22596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…core#22568) This reverts commit 50e0b07.
|
See the second commit in this PR for the fix to the lsan issue. |
|
LGTM; can you also mention in the commit message that this makes the calloc symbol handled more like malloc and free? |
dschuff
approved these changes
Sep 20, 2024
|
This seems to be breaking test_externref_emjs_dynlink in UBSan mode: |
|
test_externref_emjs_dylink uses MAIN_MODULE=2. |
|
The |
|
ah. so can we fix it by just adding that to the deps? or maybe conditionally? |
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Sep 27, 2024
This change reverts part of emscripten-core#22596. A better fix for this would be to add the missing deps to `--symbols-only` but this change seems like the quickest fix.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Sep 27, 2024
This change reverts part of emscripten-core#22596. A better fix for this would be to add the missing deps to `--symbols-only` but this change seems like the quickest fix.
|
(a) fix is here: #22650 |
dschuff
pushed a commit
that referenced
this pull request
Sep 27, 2024
This change reverts part of #22596. A better fix for this would be to add the missing deps to `--symbols-only` but this change seems like the quickest fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 50e0b07.
This change also adds calloc to the list of symbols that we provide
emscripten_builtin_variants for.