[file_packager] Convert preload caching functions to async. NFC #24885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Part 3. Also best viewed with ignore whitespace. |
sbc100
force-pushed
the
file_packager_async_part3
branch
2 times, most recently
from
31887e3 to
ae82d77
Compare
kripken
approved these changes
Aug 8, 2025
sbc100
changed the title
sbc100
changed the title
sbc100
force-pushed
the
file_packager_async_part3
branch
2 times, most recently
from
89deaf7 to
5f9ae76
Compare
kripken
approved these changes
Aug 8, 2025
sbc100
force-pushed
the
file_packager_async_part3
branch
from
5f9ae76 to
02b795e
Compare
sbc100
added a commit
that referenced
this pull request
Aug 8, 2025
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Aug 8, 2025
Part 4 in the sequence following emscripten-core#24882, emscripten-core#24883 and emscripten-core#24885.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Aug 8, 2025
Part 4 in the sequence following emscripten-core#24882, emscripten-core#24883 and emscripten-core#24885.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Aug 8, 2025
Part 4 in the sequence following emscripten-core#24882, emscripten-core#24883 and emscripten-core#24885.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Aug 8, 2025
Part 4 in the sequence following emscripten-core#24882, emscripten-core#24883 and emscripten-core#24885.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Aug 8, 2025
Part 4 in the sequence following emscripten-core#24882, emscripten-core#24883 and emscripten-core#24885.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Aug 8, 2025
Part 4 in the sequence following emscripten-core#24882, emscripten-core#24883 and emscripten-core#24885.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Aug 9, 2025
Part 4 in the sequence following emscripten-core#24882, emscripten-core#24883 and emscripten-core#24885.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Aug 11, 2025
Part 4 in the sequence following emscripten-core#24882, emscripten-core#24883 and emscripten-core#24885.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 3 functions related to IDB caching of preload data are now marked as
async. This means that they return promises instead of using callbacks.Followup to #24882 and #24883