[file_packager] Convert fetchRemotePackage to async. NFC #24893
Conversation
sbc100
changed the title
sbc100
force-pushed
the
file_packager_async_part4
branch
4 times, most recently
from
e5efcc8 to
13305e0
Compare
sbc100
force-pushed
the
file_packager_async_part4
branch
from
13305e0 to
f874811
Compare
Part 4 in the sequence following emscripten-core#24882, emscripten-core#24883 and emscripten-core#24885.
| const iterate = () => reader.read().then(handleChunk).catch((cause) => { | ||
| return Promise.reject(new Error(`Unexpected error while handling : ${response.url} ${cause}`, {cause})); | ||
| }); | ||
| const chunks = []; |
There was a problem hiding this comment.
Anything here and on can be removed nowadays - all browsers we care about support response.arrayBuffer() so it's enough to return just that.
There was a problem hiding this comment.
Ah, or is the goal to show actual progress? Then perhaps the opposite, remove the polyfill.
There was a problem hiding this comment.
yes, the goal is to show progress.
I don't know which polyfill is being referred to above, but its not something emscripten includes.
Maybe it can be remove now? It was added in #22016 but I don't see anything about if/when the polyfill might be used. Probably best to leave that to a separate cleanup PR.
sbc100
force-pushed
the
file_packager_async_part4
branch
from
f874811 to
6d48d48
Compare
| while (1) { | ||
| var {done, value} = await reader.read(); | ||
| if (done) break; |
There was a problem hiding this comment.
We can also do
| while (1) { | |
| var {done, value} = await reader.read(); | |
| if (done) break; | |
| for await (var value of reader) { |
There was a problem hiding this comment.
That is a very new JS feature though right? I'll maybe leave that as a followup since its not a feature we currently depend onn
There was a problem hiding this comment.
Hm relatively new, yeah.
Part 4 in the sequence following #24882, #24883 and #24885.