Don't emit code to call main if there is no main #5850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You should be able to put these lines behind |
|
(That jsifier.js looks very Python-ish, I incorrectly thought they are even invalid 😮) |
saschanaz
reviewed
Nov 26, 2017
| @@ -163,6 +163,7 @@ dependenciesFulfilled = function runCaller() { | |||
| if (!Module['calledRun']) dependenciesFulfilled = runCaller; // try this again later, after new deps are fulfilled | |||
| } | |||
|
|
|||
| #if HAS_MAIN | |||
| Module['callMain'] = Module.callMain = function callMain(args) { | |||
There was a problem hiding this comment.
Module['callMain'] and Module.callMain are same in JS, can we remove the latter part?
There was a problem hiding this comment.
Yes, I'm actually not sure why we have this pattern. I suspect it is very old, and either worked around a closure compiler bug or a bug in our understanding of closure compiler ;) We should remove it across the codebase, leaving only Module['X'].
|
Thanks @curiousdannii , adding. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.