Test + fix for recent main() change #5871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t runtime. this adds a runtime assertion with an explanation and a workaround, and fixes an existing test that broke
dschuff
approved these changes
Nov 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5850 checks at compile time if
main()exists. Turns out that we very hackishly allowedmain()to be added at runtime from JS, and used this in a test. I doubt anyone ever used this "feature", but there is a simple workaround (theonRuntimeInitializedcallback, which is made for basically that). This PR fixes the test that broke, and adds a runtime assertion with a explanation of what to do to avoid this, and a test for that.