Skip to content

2.0.24 #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

2.0.24 #835

wants to merge 1 commit into from

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Jun 7, 2021

No description provided.

@sbc100 sbc100 requested review from kripken and dschuff June 7, 2021 14:57
@dschuff
Copy link
Member

dschuff commented Jun 7, 2021

Should we do this one as LTO?

@sbc100
Copy link
Collaborator Author

sbc100 commented Jun 7, 2021

Did we manage to get any feedback on the last LTO release?

I guess there any issues that come up we can immediately release 2.0.25?

I guess we can/should trigger and LTO build in any case?

@dschuff
Copy link
Member

dschuff commented Jun 7, 2021

Yes, in any case, https://chromium-review.googlesource.com/c/emscripten-releases/+/2945802

We got feedback that it worked and they were able to compile. No feedback on performance, but not surprises either. Probably good enough.

@sbc100
Copy link
Collaborator Author

sbc100 commented Jun 7, 2021

Sounds good to me. Does that mean we should abandon this PR and wait for the LTO build? Or at least abandon this once the LTO build is released?

@kripken
Copy link
Member

kripken commented Jun 7, 2021

The LTO builds are larger, though - perhaps we should measure the size/speed tradeoff first? E.g. if it makes the emscripten test suite on CI here faster that would be very compelling I think.

@dschuff
Copy link
Member

dschuff commented Jun 7, 2021

The emscripten test suite here always uses tot doesn't it? In that case only the few CI runs that happen to start between the LTO build and the next build would get it.

@kripken
Copy link
Member

kripken commented Jun 7, 2021

Oh, right... nevermind that idea then.

@sbc100
Copy link
Collaborator Author

sbc100 commented Jun 7, 2021

Actually I think we need to wait until emscripten-core/emscripten#14403 rolls in to tag a release.

@sbc100 sbc100 closed this Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants