Fix for test_dynamic_link_glemu #14403
Merged
+8
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem was the `GL` was being found in `system_libs_map` before it was being looked up in `system_libs_map`. This test was broken in #14351. Sadly this test doesn't run under chrome due to its use `@requires_sync_compilation`
|
Ha.. this failure was indeed reported in the CI for #14351 but I ignored it firefox failures because the real failure was hidden among all the flakes. I guess we still have value in the firefox testing! At least until we can remove |
This was referenced Jun 7, 2021
|
Landing TBR to green the tree. |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was the
GLwas being found insystem_libs_mapbeforeit was being looked up in
map_to_js_libs.This test was broken in #14351. Sadly this test doesn't run under
chrome due to its use
@requires_sync_compilation