-
-
Notifications
You must be signed in to change notification settings - Fork 7k
updating to bootstrap 3.2.0 #1873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Be good to get before and after screenshots of this in order to review. Also note the failing tests. |
</ul> | ||
</div> | ||
<ul class="dropdown-menu"> | ||
<li>{% optional_logout request %}</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the failing tests are here:
django.template.base.TemplateSyntaxError: 'optional_logout' did not receive value(s) for the argument(s): 'user'
optional_logout
needs the user
parameter:
{% optional_logout request user %}
If you can fix that we can see what's left.
Great thanks! Looks like the forms need the horizontal style applied, otherwise nice. |
they've still got form-horizontal, but that doesn't do much in BS3. I can put in the grid classes. |
This'd be what we want, no?... http://getbootstrap.com/css/#forms-horizontal |
Ya, but in BS2 you could leave it at that basically. Now you have to add column classes to the label and inputs. |
Want to sling up a screenshot of the latest form styling? |
@tomchristie — I'll have a look at this today. |
I've had a look and would say there are a couple of alignment issues still to fix. The main "HTML Form" looks good to go: BUT the "Raw" form is misaligned: The log in form also needs so love: Beyond that, @dryan is there anything you see as still to do? |
@dryan I'm able to pick this up if you need help. |
The bootstrap 3 update is addressed in v3. |
@tomchristie dropping this one definitely makes sense if it's already done on v3. |
@tomchristie yes if this is coming on v3, no need to worry about it here. |
Made the changes to get the browseable API into Bootstrap 3.
Addresses #1085