TokenAdmin: add 'user' to autocomplete_fields

[jieter]

TokenAdmin is unusable with a big number of user records (in this case ~150k). Django 2.0 added the ModelAdmin.autocomplete_fields option to use select2 to provide a better user experience.

If support for django 1.11 is dropped, this change would make the TokenAdmin usable again.

[tomchristie]

"If support for django 1.11 is dropped"

Presumably there's no reason we can't accept this change, without having to drop Django 1.11.

It should be a problem to set the "autocomplete_fields" attribute, even if it's not actually used right?

[jieter]

You are right, adding the option doesn't matter to django==1.11.

[sourcepirate]

This one broke the existing code.

ERRORS:
<class 'rest_framework.authtoken.admin.TokenAdmin'>: (admin.E040) ModelAdmin must define "search_fields", because it's referenced by TokenAdmin.autocomplete_fields.

When running django 2.2.3 with drf 3.10.0.
Do you think we can add user to search fields ?

[rpkilby]

Hi @sourcepirate, could you open a new issue to track this?

[sourcepirate]

Sure!

from django.contrib import admin
from .models import User


class UserAdmin(admin.ModelAdmin):

    search_fields = ("email",)


# Register your models here.
admin.site.register(User, UserAdmin)

I need to modify my admin.py to the above to avoid the error.