Skip to content

Version 3.10.1 #6817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 17, 2019
Merged

Version 3.10.1 #6817

merged 3 commits into from
Jul 17, 2019

Conversation

tomchristie
Copy link
Member

@tomchristie tomchristie commented Jul 17, 2019 •
edited
Loading

Ensure that requiring uritemplate, doe not also require coreapi

Refs #6814

Don't include autocomplete fields on TokenAuth admin

Closes #6808
Refs #6762

I think we should instead document how to customize the TokenAuth admin, using an autocomplete field as an example case. (Looking into it I can see that expanding on #3831 slightly is what we'd want)

Also closes #6811

@tomchristie tomchristie mentioned this pull request Jul 17, 2019
Closed
carltongibson
carltongibson reviewed Jul 17, 2019
View reviewed changes
rest_framework/compat.py Outdated
except ImportError:
coreapi = None

# uritemplate is required for OpenAPI schema generation
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uritemplate is required for both CoreAPI and OpenAPI schema generation.

@tomchristie tomchristie merged commit 044252a into master Jul 17, 2019
@tomchristie tomchristie deleted the 3.10.1 branch July 17, 2019 13:17
@tomchristie
Copy link
Member Author

I'm having some issues building the release on my machine. @carltongibson any chance you'd be able to try giving it a go? Failing that I'll be able to try from my work machine tomorrow.

I keep getting "Checking distribution dist/djangorestframework-3.10.1-py3-none-any.whl: warning: long_description_content_type missing. defaulting to text/x-rst." despite having ensured the twine is at the latest version, and despite us having a long_description_content_type in our setup.py.

I tried just pushing it to PyPI regardless but that failed with the same error and a 400.

@tomchristie
Copy link
Member Author

Managed to deploy to PyPI, but I needed to entirely drop the long_description in order to get there. 😕
I'll have a dig into it again on the next version we release.

@rpkilby
Copy link
Member

rpkilby commented Jul 17, 2019 •
edited
Loading

I'm guessing you have an outdated version of wheel installed - probably running into #4012 (comment)

@tomchristie
Copy link
Member Author

Maybe. I created a completely clean virtualenv, so it’s not obvious to me how that’d be, but I’ll take a deeper look next time.

@rpkilby
Copy link
Member

rpkilby commented Jul 17, 2019

What version of wheel is installed? Can you run a quick pip list check?

@johnthagen johnthagen mentioned this pull request Jul 18, 2019
Closed
pchiquet pushed a commit to pchiquet/django-rest-framework that referenced this pull request Nov 17, 2020
@tomchristie
Version 3.10.1 (encode#6817)
2978c2e 
* Ensure that requiring 'uritemplate' does not also require 'coreapi'

* Don't include autocomplete fields on TokenAuth admin

* Version 3.10.1
sigvef pushed a commit to sigvef/django-rest-framework that referenced this pull request Dec 3, 2022
@tomchristie @sigvef
Version 3.10.1 (encode#6817)
3e409b4 
* Ensure that requiring 'uritemplate' does not also require 'coreapi'

* Don't include autocomplete fields on TokenAuth admin

* Version 3.10.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carltongibson carltongibson carltongibson left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rest_framework 3.10.0 - crash with runserver
3 participants
@tomchristie @rpkilby @carltongibson