Remove _exit_tree methods from Simple nodes #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need for this cleanup because from docs: [1] > If the node has children, its _exit_tree callback will be called last, > after all its children have left the tree. Also because: [2] > when a node is freed with Object.free or queue_free, it will also free > all its children. Further, this removes the sprite and collision while in the editor when the user switches to another scene tab #213. [1] https://docs.godotengine.org/en/stable/classes/class_node.html#class-node-private-method-exit-tree [2] https://docs.godotengine.org/en/stable/classes/class_node.html#description Fixes #213
dbnicholson
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Good call. I totally misunderstood what _exit_tree was for. I think the reason I added that was that I was worried that sprite and/or collision would be created but then changed before before they were added to the node. But that can't happen with the current code since their created and added all within _ready.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need for this cleanup because from docs: [1]
Also because: [2]
Further, this removes the sprite and collision while in the editor when the user switches to another scene tab #213.
[1] https://docs.godotengine.org/en/stable/classes/class_node.html#class-node-private-method-exit-tree
[2] https://docs.godotengine.org/en/stable/classes/class_node.html#description
Fixes #213