SimpleCharacter: Don't impose a collision shape #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need for this cleanup because from docs: [1] > If the node has children, its _exit_tree callback will be called last, > after all its children have left the tree. Also because: [2] > when a node is freed with Object.free or queue_free, it will also free > all its children. Further, this removes the sprite and collision while in the editor when the user switches to another scene tab #213. [1] https://docs.godotengine.org/en/stable/classes/class_node.html#class-node-private-method-exit-tree [2] https://docs.godotengine.org/en/stable/classes/class_node.html#description Fixes #213
Change the logic so there is no fallback 100x100 collision shape if a texture is not provided. This way the user can customize their character by adding their own sprites and collision shapes as node children. The simple setup of passing a texture is still maintained. Although it has been found to be inflexible (can't resize the texture from the canvas, can't change the shape of the collision). Addresses #215
manuq
requested review from
dylanmccall,
cassidyjames,
starnight and
dbnicholson
|
Note: this is on top of #214 |
manuq
changed the title
starnight
reviewed
Sep 6, 2024
| for label in _score_labels.values(): | ||
| label.queue_free() | ||
| _score_labels.clear() | ||
|
|
There was a problem hiding this comment.
This benefits from add_child().
starnight
reviewed
Sep 6, 2024
| if sprite: | ||
| sprite.queue_free() | ||
| sprite = null | ||
|
|
There was a problem hiding this comment.
These benefit from add_child().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the logic so there is no fallback 100x100 collision shape if a
texture is not provided. This way the user can customize their character
by adding their own sprites and collision shapes as node children. The
simple setup of passing a texture is still maintained. Although it has
been found to be inflexible (can't resize the texture from the canvas,
can't change the shape of the collision).
Addresses #215