Skip to content

Invalid "+" symbol generated in getCSSModuleLocalIdent #12048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yangjocy opened this issue Feb 11, 2022 · 3 comments
Closed

Invalid "+" symbol generated in getCSSModuleLocalIdent #12048

yangjocy opened this issue Feb 11, 2022 · 3 comments

Comments

@yangjocy
Copy link

yangjocy commented Feb 11, 2022

Dup of #11775.

Describe the bug

The output of getCSSModuleLocalIdent() in react-dev-utils might include invalid + symbol, like 'SidePanel_slideIn__xwW+q'. That would invalidate corresponding CSS classes and cause style error.

Did you try recovering your dependencies?

Yes.

Environment

react-dev-utils: v12.0.0, the lastest

Steps to reproduce

It is difficult to reproduce because the class-names are auto-generated.

Expected behavior

+ as in class names is removed.

Actual behavior

The symbol is there. screenshot

I'd be happy to submit a PR if this makes sense and I didn't miss something obvious. Thank you!

@mikeaustin
Copy link

This was originally reported for css-loader, since I thought it was using the default localName generator.

webpack-contrib/css-loader#1414

@pstrh
Copy link

pstrh commented Feb 14, 2022

@yangjocy I think this is a duplicate of #11775. I submitted a PR #12013 to fix it.

@yangjocy
Copy link
Author

@pstrh Thanks for reminding, I'll link them and close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants