-
-
Notifications
You must be signed in to change notification settings - Fork 27k
Added app name as hash salt for css modules ident #12013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hi @pstrh! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
context: undefined, | ||
hashSalt: undefined, | ||
regExp: null, | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With ccs-loader v6 / webpack v5 hashPrefix was removed in favor of hashSalt. hashSalt is undefined by default.
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
'md5', | ||
'base64', | ||
'base64url', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes #11775. base64url
encoding (introduced in node 14) prevents +
and /
in generated hashes.
Fixes CSS Module class name collisions (#9134 and #10190) by adding the app name as a hash salt. The change preserves #6875. The css module hash is stable within the project but globally unique (as long as the app name is unique).
Test steps:
Previous: The generate css module hash stays the same.
Now: The generate css module hash changes as the app name has been changed.
Please let me know if you need more information.