Skip to content

Enable offline Yarn support #1235

Closed
Closed
@gaearon

Description

@gaearon

It appears that it doesn't work. Shall we opt in?

screen shot 2016-12-11 at 09 53 38

Activity

sylvainbannier

sylvainbannier commented on Dec 11, 2016

@sylvainbannier

I have issues with offline support in yarn v0.17.10 yarnpkg/yarn#2162. Waiting, for triage. If this is confirmed, then I guess CRA should wait for a fix in Yarn.

gaearon

gaearon commented on Dec 11, 2016

@gaearon
ContributorAuthor

Note that I also tried --offline and it didn't work because it requested latest whereas we only have a specific version in cache (for example 0.8.4). I wish there was a way to "agree" to use whatever local version we have if there is no network connection.

Related: yarnpkg/yarn#1277 (comment)

Possible improvement is to give user option [y/n]-prompt to use latest local version. (out of scope for this PR, should be feature request?)

gaearon

gaearon commented on Dec 12, 2016

@gaearon
ContributorAuthor
voxsim

voxsim commented on Jan 17, 2017

@voxsim
Contributor

@gaearon please let me know if this works right now ;)

gaearon

gaearon commented on Jan 18, 2017

@gaearon
ContributorAuthor

Does it require any flags?

voxsim

voxsim commented on Jan 20, 2017

@voxsim
Contributor

@gaearon sorry for the late answer, but I lose some time to understand where I have to change the yarnpkg, to use what I build instead of the global package :)

Btw if you add --offline after --dev and --exact it should work from the next version!

gaearon

gaearon commented on Jan 20, 2017

@gaearon
ContributorAuthor

Want to send a PR?

voxsim

voxsim commented on Jan 20, 2017

@voxsim
Contributor

Sure

gaearon

gaearon commented on Jan 20, 2017

@gaearon
ContributorAuthor

Thx

voxsim

voxsim commented on Jan 20, 2017

@voxsim
Contributor

@gaearon I prefer to wait for the PR, because if you add --prefer-offline still don't work properly. I mean when you are online it does not switch from offline to online and other stuff, the road seems long I think you should reopen #2225. I will work on that because It could be useful for me creating react app offline ;)

Apart from this, do you think some end-to-end tests for create-react-app could be useful? Test manually the scripts every time is challenging :P

7 remaining items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @sylvainbannier@gaearon@voxsim

        Issue actions

          Enable offline Yarn support · Issue #1235 · facebook/create-react-app