Skip to content

fix-1221: offline flag, metadata property nonexistent (#1221) #1277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from Oct 24, 2016
Merged

fix-1221: offline flag, metadata property nonexistent (#1221) #1277

merged 3 commits into from Oct 24, 2016

Conversation

ghost
Copy link

@ghost ghost commented Oct 19, 2016

Summary

--offline flag is not working. #1221

  • Problem: nonexistent property prevented any cached package from satisfying.
  • Solution: use correct property name from readPackageMetadata

Test plan

$ yarn add [package]
$ rm -rf ./node_modules && rm -f yarn.lock
$ yarn add [package]@version --offline

Improvement

Without version: latest range is used and is not available, this will list the possible versions via the error: Possible versions: ${Object.keys(body.versions).join(', ')}. Possible improvement is to give user option [y/n]-prompt to use latest local version. (out of scope for this PR, should be feature request?)

@ghost ghost changed the title fix-1221: offline flag, metadata property nonexistent fix-1221: offline flag, metadata property nonexistent (#1221) Oct 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants