feat(babel-preset-react-app): add support for logical assignment #10832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krotovic
requested review from
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
|
Can this be finished before version 5 is released? Edit: If you use typescript, then logical assignment works |
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
|
No one gonna review that? Really? :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for logical assignment operators into
babel-preset-react-app.This PR is based on issue #10734
I have also updated E2E tests inside
react-scriptsso I can test it by running./tasks/local-test.sh --test-suite kitchensink.This is the only way I could test it. When I tried running all E2E tests it failed when publishing to local repository inside this test suite.