-
Notifications
You must be signed in to change notification settings - Fork 24.7k
☂️ Help us Kotlin-ify React Native - Round 3 #50513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account

Comments

Let's go 🚀 |
I would like to migrate: react/modules/blob/FileReaderModule.java |
I would like to migrate react/modules/blob/BlobProvider.java |
I would like to migrate react/bridge/DynamicFromObject.java |
I would like to migrate react/uimanager/ReactStylesDiffMap.java |
I would like to migrate react/views/textinput/ReactEditTextInputConnectionWrapper.java |
I'd like to migrate react/bridge/DynamicFromArray.java |
Hello, I'd like to migrate Edit: tracked in #50597 |
Hello, I'd like to migrate react/runtime/ReactLifecycleStateManager.java |
react/bridge/UiThreadUtil.java Can you assign me this @mateoguzmana |
Hi @mateoguzmana I could help with react/views/text/frescosupport/FrescoBasedReactTextInlineImageSpan.java |
Summary: Rewrite of JavaModuleWrapper from Java to Kotlin in scope of #50513 ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [ANDROID] [CHANGED] - Migrated JavaModuleWrapper to Kotlin Pull Request resolved: #50882 Test Plan: Test RNTester using old arch. SampleLegacyModule is the one I've used, it needs to be enabled for old arch though (RNTesterApplication.kt -> getPackages & getReactModuleInfoProvider). I may enable SampleLegacyModule for old arch to make testing easier. mateoguzmana It breaks on `getDynamic` on old arch, but I could filter these from examples or add some fallback in SampleLegacyModule.kt for old arch. Reviewed By: cortinico Differential Revision: D73576099 Pulled By: javache fbshipit-source-id: c940be27133258fa589571a600435fa478e6b51e
Summary: Rewrite of JSBundleLoader from Java to Kotlin in scope of #50513 ## Changelog: [ANDROID] [CHANGED] - Migrated JSBundleLoader to Kotlin <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests Pull Request resolved: #50911 Test Plan: Tested using RNTester app, on both old and new arch, and tested by navigating to multiple pages Reviewed By: cortinico Differential Revision: D73649145 Pulled By: javache fbshipit-source-id: 7ef1fc1ea1c53a8b914ae1aada1966e64b4c3d80
It seems that there are files that need to be migrated to Kotlin in |
Summary: Rewrite of the Inspector class from Java to Kotlin in scope of #50513 ## Changelog: [ANDROID] [CHANGED] - Migrated Inspector to Kotlin Pull Request resolved: #50947 Test Plan: Tested using RNTester app, on both old and new arch, and tested by navigating to multiple pages Reviewed By: cortinico Differential Revision: D73767386 Pulled By: javache fbshipit-source-id: e0098568aa0ed9863503e206a88d3b171c8f9966
Hi, let's contribute, any pending files please assign it to me. |
This comment has been minimized.
This comment has been minimized.
Summary: This PR aims to migrate ViewGroupManager to kotlin as part of #50513 ## Changelog: [ANDROID][CHANGED]Migrate ViewGroupManager to kotlin Pull Request resolved: #50895 Test Plan: Tested with RN tester with old and new arch Reviewed By: javache Differential Revision: D73770843 Pulled By: cortinico fbshipit-source-id: 45959a8bf512b3590ca8bc64dac281e13fa41ca3
Hello, if there will be anything just mention me, It would be a pleasure to contribute. |
Would be happy to pick other files in future if there are new files required the java to kotlin migration. |
Hi @mateoguzmana, I have raised a PR: #51085 |
Hi, I would like to contribute, pls assign to me any new files that require migration, thanks! |
Hi, is there any thing for me , let me know , i would like to contribute. |
Hi, I am also eager to contribute |
Hey @mateoguzmana, You can pass on my task, I won't be able to do it. So sorry for not replying sooner! |
@mateoguzmana i will do it if its possible |
No problem at all, thanks for letting us know! @l2hyunwoo, since you were first among the others who showed interest, I've re-assigned react/bridge/BaseJavaModule.java to you. To everyone else — it's awesome to see so much interest! At the moment, we don’t have more files available for community contribution, but I’ll definitely try to bring this up and see if there is another initiative to get more folks involved somewhere in the future. :) |
Hi, I can pick the migration for this file react/LazyReactPackage.java as I can see it has no activity for the past week |
Hi @mateoguzmana, I have applied changes from cr: #51085 |
Hi @mateoguzmana JavaScriptModuleRegistry has already been migrated by @fabriziocucci , I didn't understand why he migrated without even having the file signed for him, but it's already done. |
Hey @gustavoabel, apologies for taking over the conversion of that particular file, it was definitely unintentional, I didn't notice it was assigned already! 🙏 |
Is this issue open? If yes, can I pick this up? Are there any specific guidelines or community I should follow? |
I would love to work on this Issue |

Uh oh!
There was an error while loading. Please reload this page.
☂️ Help us Kotlin-ify React Native - Round 3
Hey all 👋
After the successful second round, we're back with another round of tasks to help us improve Kotlin support in React Native core. In this stage we are looking for help to migrate a few more files to Kotlin.
How to work
If you wish to grab one of the tasks, you should:
Code formatting
Please use KtFmt to format Kotlin classes.
You can use the web UI to reformat directly from the browser.
Migrating files to Kotlin
Please act as follow:
Other important things to take into account:
mMyAwesomeProperty
should becomemyAwesomeProperty
newArchEnabled=false
in packages/rn-tester/android/app/gradle.propertiesList of files to migrate
The text was updated successfully, but these errors were encountered: