Skip to content

refactor: Rewrite JSBundleLoader from Java to Kotlin #50911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

yogeshpaliyal
Copy link
Contributor

Summary:

Rewrite of JSBundleLoader from Java to Kotlin in scope of #50513

Changelog:

[ANDROID] [CHANGED] - Migrated JSBundleLoader to Kotlin

Test Plan:

Tested using RNTester app, on both old and new arch, and tested by navigating to multiple pages

@facebook-github-bot
Copy link
Contributor

Hi @yogeshpaliyal!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@yogeshpaliyal yogeshpaliyal force-pushed the migrateJSBundleLoaderKt branch from a5aa180 to c6152af Compare April 24, 2025 18:32
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Apr 24, 2025
Copy link
Collaborator

@mateoguzmana mateoguzmana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this! Some small remarks.

@mateoguzmana mateoguzmana requested a review from cortinico April 25, 2025 07:19
@facebook-github-bot
Copy link
Contributor

@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Apr 25, 2025
@facebook-github-bot
Copy link
Contributor

@javache merged this pull request in de165a2.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @yogeshpaliyal in de165a2

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants