Back out "fix: avoid race condition crash in [RCTDataRequestHandler invalidate]" #49797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
…nvalidate]" Summary: Backing D70314889 as it was breaking some internal tests. I verified that before the backout the tests were failing and after the backout they were not. ## Changelog: [iOS][Changed] - Reverted fix: avoid race condition crash in [RCTDataRequestHandler invalidate]. Reviewed By: Abbondanzo Differential Revision: D70511155
|
This pull request was exported from Phabricator. Differential Revision: D70511155 |
|
This pull request was exported from Phabricator. Differential Revision: D70511155 |
cipolleschi
force-pushed
the
export-D70511155
branch
from
eb24caf to
2bba994
Compare
|
This pull request has been merged in 53eaf3e. |
|
This pull request was successfully merged by @cipolleschi in 53eaf3e When will my fix make it into a release? | How to file a pick request? |
react-native-bot
pushed a commit
that referenced
this pull request
Mar 28, 2025
…nvalidate]" (#49797) Summary: Pull Request resolved: #49797 Backing D70314889 as it was breaking some internal tests. I verified that before the backout the tests were failing and after the backout they were not. ## Changelog: [iOS][Changed] - Reverted fix: avoid race condition crash in [RCTDataRequestHandler invalidate]. Reviewed By: Abbondanzo Differential Revision: D70511155 fbshipit-source-id: 276f6947aa6bb648c9c9eeb5c342f336acc8a26f
|
This pull request was successfully merged by @cipolleschi in 0bd7b4e When will my fix make it into a release? | How to file a pick request? |
This was referenced Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Backing D70314889 as it was breaking some internal tests.
I verified that before the backout the tests were failing and after the backout they were not.
Changelog:
[iOS][Changed] - Reverted fix: avoid race condition crash in [RCTDataRequestHandler invalidate].
Differential Revision: D70511155