Fix issue with zIndex child removal #49900
Conversation
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D70795631 |
|
This pull request was exported from Phabricator. Differential Revision: D70795631 |
Summary: This appears to fix an issue where removing a sibling with zIndex breaks drawing of the next sibling. ## Changelog [Android][Fixed] Fixes issue with z-indexed sibling removal Differential Revision: D70795631
|
This pull request was exported from Phabricator. Differential Revision: D70795631 |
Summary: Pull Request resolved: facebook#49900 This appears to fix an issue where removing a sibling with zIndex breaks drawing of the next sibling. ## Changelog [Android][Fixed] Fixes issue with z-indexed sibling removal Differential Revision: D70795631
|
Hi! We also introduced a change in reanimated so that even without the change in RN the problem was fixed. I created the PR because it seemed to me that removing already removed views shouldn't decrease the counter. But maybe there is some flow, where the view is already removed when it gets to this function (and it's a valid removal). |
Summary: This appears to fix an issue where removing a sibling with zIndex breaks drawing of the next sibling. The theory is that eager return in `onViewRemoved` prevents the view from reverting into a state where it no longer uses custom draw order. However, tracing back history, this eager return was [added](facebook#43389) to fix a bug in Reanimated. cc bartlomiejbloniarz to confirm if [this Reanimated issue](software-mansion/react-native-reanimated#5715) resurfaces from this change. Fixes facebook#49838 ## Changelog [Android][Fixed] Fixes issue with z-indexed sibling removal Differential Revision: D70795631
rozele
force-pushed
the
export-D70795631
branch
from
729a0ce to
1c52230
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70795631 |
|
This pull request was successfully merged by @rozele in 34ae9fa When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in 34ae9fa. |
|
@bartlomiejbloniarz @RSNara Can we please release this fix for 0.77 ? 🙏 Also, Is it enough this change or you must release also the changes mentioned here to make it work? |
Summary: Pull Request resolved: #49900 This appears to fix an issue where removing a sibling with zIndex breaks drawing of the next sibling. The theory is that eager return in `onViewRemoved` prevents the view from reverting into a state where it no longer uses custom draw order. However, tracing back history, this eager return was [added](#43389) to fix a bug in Reanimated. cc bartlomiejbloniarz to confirm if [this Reanimated issue](software-mansion/react-native-reanimated#5715) resurfaces from this change. Fixes #49838 ## Changelog [Android][Fixed] Fixes issue with z-indexed sibling removal Reviewed By: NickGerleman, cipolleschi Differential Revision: D70795631 fbshipit-source-id: 500af92226be29af73f36f911ffff27a0c083ae9
|
This pull request was successfully merged by @rozele in 31e09bc When will my fix make it into a release? | How to file a pick request? |
Summary: Pull Request resolved: #49900 This appears to fix an issue where removing a sibling with zIndex breaks drawing of the next sibling. The theory is that eager return in `onViewRemoved` prevents the view from reverting into a state where it no longer uses custom draw order. However, tracing back history, this eager return was [added](#43389) to fix a bug in Reanimated. cc bartlomiejbloniarz to confirm if [this Reanimated issue](software-mansion/react-native-reanimated#5715) resurfaces from this change. Fixes #49838 ## Changelog [Android][Fixed] Fixes issue with z-indexed sibling removal Reviewed By: NickGerleman, cipolleschi Differential Revision: D70795631 fbshipit-source-id: 500af92226be29af73f36f911ffff27a0c083ae9
|
This pull request was successfully merged by @rozele in eeb9612 When will my fix make it into a release? | How to file a pick request? |
Summary:
This appears to fix an issue where removing a sibling with zIndex breaks drawing of the next sibling. The theory is that eager return in
onViewRemovedprevents the view from reverting into a state where it no longer uses custom draw order. However, tracing back history, this eager return was added to fix a bug in Reanimated (see #43389). cc @bartlomiejbloniarz to confirm if this Reanimated issue resurfaces from this change.Fixes #49838
Changelog
[Android][Fixed] Fixes issue with z-indexed sibling removal
Differential Revision: D70795631