findComponentRoot warning is misleading when logged from a transaction close #767
Comments
sophiebits
added a commit
to sophiebits/react
that referenced
this issue
Dec 31, 2013
Fixes facebook#767. This essentially reverts 738de8c. We could store some sort of flag to silence the console error here but since we've made significant improvements in markup wrapping, this error is fairly rare now. We'll also have validation of node structure soon in facebook#735.
josephsavona
pushed a commit
that referenced
this issue
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If findComponentRoot throws an exception during a Transaction close (specifically, in ReactMountReady.notifyAll) after the body of the transaction threw an exception, then it logs an error (using console.error) immediately, like so:
The error it throws is silenced by Transaction.perform in favor of the earlier error thrown by the wrapped method, but the findComponentRoot error is logged first, which is misleading.
The text was updated successfully, but these errors were encountered: