Skip to content

Remove sometimes-confusing console error #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2014

Conversation

sophiebits
Copy link
Collaborator

Fixes #767. This essentially reverts 738de8c.

We could store some sort of flag to silence the console error here but since we've made significant improvements in markup wrapping, this error is fairly rare now. We'll also have validation of node structure soon in #735.

Fixes facebook#767. This essentially reverts 738de8c.

We could store some sort of flag to silence the console error here but since we've made significant improvements in markup wrapping, this error is fairly rare now. We'll also have validation of node structure soon in facebook#735.
@ghost ghost assigned sebmarkbage Jan 7, 2014
sebmarkbage added a commit that referenced this pull request Jan 7, 2014
Remove sometimes-confusing console error
@sebmarkbage sebmarkbage merged commit c28e1f2 into facebook:master Jan 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

findComponentRoot warning is misleading when logged from a transaction close
2 participants