[ReactTransitionGroup] Entry transition only when adding to an existing group #536
Conversation
|
Talked on IRC; let's add a |
|
Added |
ghost
assigned
|
OK, I'm going to work on getting this in this week. |
| container | ||
| ); | ||
| expect(a.getDOMNode().childNodes.length).toBe(1); | ||
| expect(a.getDOMNode().childNodes[0].className).toBe('yolo-enter'); |
There was a problem hiding this comment.
When I run this in our test runner it has some extra whitespace. Can you trim() it?
There was a problem hiding this comment.
Trimmed the className in the latest update, but before that I wasn't able to repro this issue by running grunt test locally.
|
Sadly this is going to have a conflict at the next sync. I think the best thing to do is to wait for @zpao to do it and rebase on top (I'm not sure what will happen if I fix the conflict internally and merge here... will probably "just work" but I'm not 100% sure how that works) |
|
I assume @zpao would then encounter a conflict when syncing… |
|
I think the right thing is for me to update my fork i.e. go ahead and break this. |
|
We're all synced so do your thang |
|
pusheen_party |
|
|
…ng group Currently if you add a new ReactTransitionGroup with some children during a render pass, the children are transitioned. This is generally not desirable (e.g. if adding a transition-enabled list that already has some items, you don't want to transition all of the initial items when first rendering the list). This diff makes it so that entry transitions are applied only when the transition group already exists. This is implemented by applying entry transitions only when the group has already been mounted.
|
👍 |
|
In ReactCSSTransitionGroup now I believe the transition happens only for new elements, so I'm going to close this out. (And ReactTransitionGroup should be flexible enough to do any custom logic you might want.) |
Currently if you add a new ReactTransitionGroup with some children during a
render pass, the children are transitioned. This is generally not desirable
(e.g. if adding a transition-enabled list that already has some items, you don't
want to transition all of the initial items when first rendering the list).
This diff makes it so that entry transitions are applied only when the
transition group already exists. This is implemented by applying entry
transitions only when the group has already been mounted.