Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/addons/transitions/ReactTransitionGroup.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ var ReactTransitionGroup = React.createClass({
transitionName: React.PropTypes.string.isRequired,
transitionEnter: React.PropTypes.bool,
transitionLeave: React.PropTypes.bool,
transitionOnMount: React.PropTypes.bool,
onTransition: React.PropTypes.func,
component: React.PropTypes.func
},
Expand All @@ -36,6 +37,7 @@ var ReactTransitionGroup = React.createClass({
return {
transitionEnter: true,
transitionLeave: true,
transitionOnMount: false,
component: React.DOM.span
};
},
Expand All @@ -62,6 +64,7 @@ var ReactTransitionGroup = React.createClass({
var children = {};
var childMapping = ReactTransitionKeySet.getChildMapping(sourceChildren);

var allowEnterTransitions = this.props.transitionOnMount || this.isMounted();
var currentKeys = ReactTransitionKeySet.mergeKeySets(
this._transitionGroupCurrentKeys,
ReactTransitionKeySet.getKeySet(sourceChildren)
Expand All @@ -76,7 +79,7 @@ var ReactTransitionGroup = React.createClass({
if (childMapping[key] || this.props.transitionLeave) {
children[key] = ReactTransitionableChild({
name: this.props.transitionName,
enter: this.props.transitionEnter,
enter: allowEnterTransitions && this.props.transitionEnter,
onDoneLeaving: this._handleDoneLeaving.bind(this, key)
}, childMapping[key]);
}
Expand All @@ -101,6 +104,7 @@ var ReactTransitionGroup = React.createClass({
transitionName: null,
transitionEnter: null,
transitionLeave: null,
transitionOnMount: null,
component: null
},
this.renderTransitionableChildren(this.props.children)
Expand Down
38 changes: 36 additions & 2 deletions src/addons/transitions/__tests__/ReactTransitionGroup-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,48 @@ describe('ReactTransitionGroup', function() {
container = document.createElement('div');
});

it('should warn after time with no transitionend', function() {
var a = React.renderComponent(
it('should not transition in initial children by default', function() {
var container;
var a;

container = document.createElement('div');
a = React.renderComponent(
<ReactTransitionGroup transitionName="yolo">
<span key="one" id="one" />
</ReactTransitionGroup>,
container
);
expect(a.getDOMNode().childNodes.length).toBe(1);
expect(a.getDOMNode().childNodes[0].className).toBe('');
});

it('should transition in initial children when specified', function() {
var container;
var a;

container = document.createElement('div');
a = React.renderComponent(
<ReactTransitionGroup transitionName="yolo" transitionOnMount={true}>
<span key="one" id="one" />
</ReactTransitionGroup>,
container
);
expect(a.getDOMNode().childNodes.length).toBe(1);
expect(a.getDOMNode().childNodes[0].className.trim()).toBe('yolo-enter');
});

it('should warn after time with no transitionend', function() {
var container;
var a;

container = document.createElement('div');
a = React.renderComponent(
<ReactTransitionGroup transitionName="yolo" transitionOnMount={true}>
<span key="one" id="one" />
</ReactTransitionGroup>,
container
);
expect(a.getDOMNode().childNodes.length).toBe(1);

setTimeout.mock.calls.length = 0;

Expand Down