Skip to content

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Aug 19, 2024

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Confirmed the action opens the properties for the current location when no items are selected
  2. Confirmed the action opens properties when a single item is selected
  3. Confirmed the action opens properties when multiple items are selected

@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Aug 19, 2024
@yaira2 yaira2 requested a review from hishitetsu August 19, 2024 15:22
Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As in code quality, LGTM otherwise.

@yaira2 yaira2 force-pushed the ya/ClassicProperties branch from 446e9b2 to 5603808 Compare August 21, 2024 01:51
Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Aug 25, 2024
@yaira2 yaira2 merged commit 8fe155c into main Aug 25, 2024
@yaira2 yaira2 changed the title Feature: Added an action to open File Explorers properties window Feature: Added an action to open File Explorers property window Aug 25, 2024
@yaira2 yaira2 deleted the ya/ClassicProperties branch August 25, 2024 01:40
@0x5bfa
Copy link
Member

0x5bfa commented Aug 25, 2024

For others referencing here: due to an issue with opening the shell property sheet from multiple selection (IShellFolder.GetUIObjectOf doesn't always work via Vanara), we decided to enable this option only when single item is selected. Future research may enable us to fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Support opening Explorer's Properties window

3 participants