Skip to content

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Oct 10, 2024

Resolved / Related Issues

I did a wrong review to this PR and found there's a GC hole.

Steps used to test these changes

None

@0x5bfa 0x5bfa added the ready for review Pull requests that are ready for review label Oct 10, 2024
@yaira2
Copy link
Member

yaira2 commented Oct 10, 2024

I tested and can confirm the action works as expected in this PR.

@yaira2 yaira2 merged commit 82c54d5 into files-community:main Oct 10, 2024
6 checks passed
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Oct 10, 2024
@0x5bfa 0x5bfa deleted the 5bfa/CQ-GCHole branch October 10, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants