-
-
Notifications
You must be signed in to change notification settings - Fork 71
[typescript] add tests and implementation for FieldArrayProps #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Once versions are bumped for final-form/final-form-arrays#8 and final-form/react-final-form#129, this one will be good to go. |
I'll check it out |
This should have been fixed by my change to Checking now to see what's the deal with the release. |
@erikras react-final-form needs a release, then needs bumped here. |
@erikras - I'm not sure why there are unrelated test failures. If you can take a look, I would appreciate it. On an unrelated note, I found more ts inaccuracies (here) - I'll work on that now, let's leave this open. |
@erikras |
@erikras I think all |
@erikras any ideas about the test failure? https://travis-ci.org/final-form/react-final-form-arrays/builds/332369245 Seems like the upstream dependencies changed and are causing a failure on the field-level validation test (that's speculation btw) |
Codecov Report
@@ Coverage Diff @@
## master #18 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 64 66 +2
Branches 16 15 -1
=====================================
+ Hits 64 66 +2
Continue to review full report at Codecov.
|
Great, thank you. This one is good to merge/release |
Published in |
Closes #17
Depends on final-form/final-form-arrays#8
Depends on final-form/react-final-form#129