Skip to content

[typescript] possibly undefined mutators (on render) are difficult to use #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2018

Conversation

rosskevin
Copy link
Contributor

@rosskevin rosskevin commented Jan 22, 2018

In a strongly typed application,FormRenderProps mutators are difficult to use because they are possibly undefined.

The first commit shows this pain (it errors), I'll look at making this a bit easier for typescript users.

Depends on final-form/final-form#68

@rosskevin
Copy link
Contributor Author

Once final-form/final-form#68 is merged/released, I can bump a version here. It needs the version bump to technically be correct since the runtime did change slightly.

@codecov
Copy link

codecov bot commented Jan 22, 2018

Codecov Report

Merging #129 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #129   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          10     10           
  Lines         165    165           
  Branches       52     52           
=====================================
  Hits          165    165

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5237673...198652e. Read the comment docs.

@erikras
Copy link
Member

erikras commented Jan 23, 2018

I upgraded the dep. ☝️

@rosskevin rosskevin deleted the form-render-mutations-defined branch January 23, 2018 14:46
@erikras
Copy link
Member

erikras commented Jan 23, 2018

Published in v3.0.5.

@lock
Copy link

lock bot commented May 31, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants