Refactor Event Listeners #289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it match iOS.
* Pull activity-scoping out ListenerRegistrationImpl--it's a totally
separate concern.
* Make the relationship between the various levels of listener clearer
in the places where we construct them.
mikelehen
approved these changes
Mar 18, 2019
| firestore.getClient(), queryListener, activity, wrappedListener); | ||
| QueryListener queryListener = firestore.getClient().listen(query, options, asyncListener); | ||
|
|
||
| return ActivityScope.bind( |
firebase-firestore/src/main/java/com/google/firebase/firestore/Query.java
Show resolved
Hide resolved
firebase-firestore/src/main/java/com/google/firebase/firestore/Query.java
Show resolved
Hide resolved
...ase-firestore/src/main/java/com/google/firebase/firestore/core/ListenerRegistrationImpl.java
Outdated
Show resolved
Hide resolved
|
/test smoke-tests-debug |
|
@wilhuff: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on iOS's event listeners I realized that the platforms have a bunch of spurious differences that don't really need to be there.
Highlights:
Note: this is running slightly in advance of forthcoming iOS changes