Add GULUserDefaults to GoogleUtilities. #1812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a workaround for NSUserDefaults crashing when setting values in the background in some situations on iOS 11. This uses the C API in order to avoid an NSNotification firing (which a class eventually tries to update the UI from the thread that set the value).
|
Will wait until Travis is green before adding reviewers. |
bstpierr
suggested changes
Sep 13, 2018
|
|
||
| @interface GULUserDefaults () | ||
|
|
||
| /// |
There was a problem hiding this comment.
Oops nice catch, will fix.
There was a problem hiding this comment.
Fixed in latest commit.
| CFStringRef _appNameRef; | ||
| } | ||
|
|
||
| + (nonnull GULUserDefaults *)standardUserDefaults { |
There was a problem hiding this comment.
Should we just use the NS_ASSUME_NONNULL for this file and others?
There was a problem hiding this comment.
Thanks, good call! Actually just caught an issue there too.
There was a problem hiding this comment.
Fixed in latest commit.
|
From travis, it looks like it doesn't work on macOS |
|
@bstpierr Travis is green and I addressed your comments. PTAL when you get a chance! :) |
bstpierr
approved these changes
Sep 14, 2018
| GULUDMessageCodeInvalidKeySet = 2, | ||
| GULUDMessageCodeInvalidObjectSet = 3, | ||
| GULUDMessageCodeSynchronizeFailed = 4, | ||
| GULUDMessageCodeLibraryDirNotFound = 5, |
There was a problem hiding this comment.
nit: It looks like this message code is never used. Not sure if this was used in a previous commit.
renkelvin
added a commit
that referenced
this pull request
Sep 14, 2018
This reverts commit ed30bc9.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for NSUserDefaults crashing when setting values
in the background in some situations on iOS 11. This uses the C API
in order to avoid an NSNotification firing (which a class eventually
tries to update the UI from the thread that set the value).