Skip to content

GULLogger - issue count synchronous getters #2610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 22, 2019
Merged

GULLogger - issue count synchronous getters #2610

merged 10 commits into from
Mar 22, 2019

Conversation

maksymmalyhin
Copy link
Contributor

  • GULLogger - provide synchronous API to get logged issues count. It is needed to simplify integration with analytics.

paulb777
paulb777 requested changes Mar 22, 2019
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed this in #2601, but GULLogger should not use NSUserDefaults. Use GULUserDefaults instead. See its history for the reasons.

@maksymmalyhin
Copy link
Contributor Author

maksymmalyhin commented Mar 22, 2019 •
edited
Loading

@paulb777 Unfortunately, I was not able to use GULUserDefaults, because it itself has GULLogger as a dependency, so I bumped into a circular dependency issue.

I can see following ways to solve the issue:

  1. Remove dependency on GULLogger from GULUserDefaults
  2. Use C API directly to manage user defaults in GULLogger or don't use user defaults at all

Probably, the first thing I would like to do is to double check if the usage of NSUserDefaults matches to the conditions for the crash described in #1812. @paulb777 @ryanwilson do you know where I can get more details on the issue?

@maksymmalyhin
Copy link
Contributor Author

@paulb777 I updated the PR to get rid of NSUserDefaults to address your comment and fix the Pod lint failure.

@maksymmalyhin maksymmalyhin requested a review from paulb777 March 22, 2019 16:39
@maksymmalyhin maksymmalyhin merged commit c6da7d6 into master Mar 22, 2019
@paulb777 paulb777 deleted the mm/log-count branch March 22, 2019 21:23
maksymmalyhin added a commit that referenced this pull request Apr 3, 2019
@maksymmalyhin
Revert "GULLogger - issue count synchronous getters (#2610)"
98cad74 
This reverts commit c6da7d6.
@maksymmalyhin maksymmalyhin mentioned this pull request Apr 3, 2019
Merged
maksymmalyhin added a commit that referenced this pull request Apr 3, 2019
@maksymmalyhin
Revert "GULLogger - count errors and warnigns" (#2714)
b2cd981 
* Revert "GULLogger: logged issue counting concurrency issue fix (#2627)"

This reverts commit 961e9b0.

* Revert "GULLogger - issue count synchronous getters  (#2610)"

This reverts commit c6da7d6.

* Revert "GULLogger - count errors and warnigns (#2601)"

This reverts commit 1e08a55.
Corrob pushed a commit that referenced this pull request Apr 25, 2019
@maksymmalyhin @Corrob
GULLogger - issue count synchronous getters (#2610)
7d99155
Corrob pushed a commit that referenced this pull request Apr 25, 2019
@maksymmalyhin @Corrob
Revert "GULLogger - count errors and warnigns" (#2714)
25bd9e0 
* Revert "GULLogger: logged issue counting concurrency issue fix (#2627)"

This reverts commit 961e9b0.

* Revert "GULLogger - issue count synchronous getters  (#2610)"

This reverts commit c6da7d6.

* Revert "GULLogger - count errors and warnigns (#2601)"

This reverts commit 1e08a55.
@firebase firebase locked and limited conversation to collaborators Oct 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

@ryanwilson ryanwilson Awaiting requested review from ryanwilson

@davidair davidair Awaiting requested review from davidair

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maksymmalyhin @paulb777 @googlebot