Skip to content

Revert "Add supporting of custom fdl domain" #1828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 14, 2018
Merged

Revert "Add supporting of custom fdl domain" #1828

merged 5 commits into from
Sep 14, 2018

Conversation

renkelvin
Copy link
Contributor

Reverts #1810

paulb777
paulb777 approved these changes Sep 14, 2018
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird that 5 commits show up in the revert list, but the files look right

@renkelvin renkelvin merged commit f151178 into master Sep 14, 2018
@renkelvin renkelvin deleted the revert-1810-custom-fdl-domain branch September 15, 2018 00:30
@renkelvin renkelvin mentioned this pull request Nov 26, 2018
Merged
@firebase firebase locked and limited conversation to collaborators Oct 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

@morganchen12 morganchen12 Awaiting requested review from morganchen12

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@renkelvin @paulb777 @googlebot