Carthage instructions for new gRPCCertificates.bundle location #2132
Conversation
| @@ -63,7 +63,7 @@ binary "https://dl.google.com/dl/firebase/ios/carthage/FirebaseStorageBinary.jso | |||
| into the Xcode project and make sure they're added to the | |||
| `Copy Bundle Resources` Build Phase : | |||
| - For Firestore: | |||
| - ./Carthage/Build/iOS/gRPC.framework/gRPCCertificates.bundle | |||
| - ./Carthage/Build/iOS/FirebaseFirestore.framework/gRPCCertificates.bundle | |||
| - For Invites: | |||
There was a problem hiding this comment.
@paulb777 Sorry I didn't think about it earlier: I have renamed the bundle in Firestore to gRPCCertificates-Firestore specifically to avoid the name clash with gRPC. I downloaded the latest Carthage zip file, and it looks like it has the bundle named gRPCCertificates.bundle, not gRPCCertificates-Firestore.bundle. So for that zip file, these instructions would work. However, I'm not sure why the older bundle name is used.
There was a problem hiding this comment.
@var-const The Carthage distribution is created from the zip distribution which also doesn't have the rename:
There was a problem hiding this comment.
Ah, I guess the distribution was created from a commit older than #2106. As long as the code and the bundle name are in sync, everything should be fine. I'll update the instructions again (to account for the renaming) before the next release.
There was a problem hiding this comment.
Right #2106 is not in https://github.com/firebase/firebase-ios-sdk/commits/release-5.13.0.
Thanks!
* master: (26 commits) Functions Interop (#2113) Add a travis cron job for CocoaPod symbol collision testing (#2154) Save schema version on downgrade, add test to verify (#2153) Silence Storage Unit Test `nil` warning. (#2150) Update versions for Release 5.14.0 (#2145) gRPC: fix cases where gRPC call could be finished twice (#2146) Fix Swizzler test warnings (#2144) Update Auth CHANGELOG.md (#2128) Make fuzz tests optional until they pass (#2143) Add support of Game Center sign in (#2127) Add test for deprecated FDLURLComponents init API. (#2133) fix a typo in integration test (#2131) Make fuzzing less verbose to avoid exceeding Travis log limit (#2126) Move to `domainURIPrefix` for FIRDynamicLinkComponents (#2119) Carthage instructions for new gRPCCertificates.bundle location (#2132) Fix pod lib lint GoogleUtilities.podspec --use-libraries regression (#2130) Avoid using default FIROptions directly. (#2124) Changelog entry for LRU GC (#2122) Revert "Add Firebase Source to Header Search Path" (#2123) Custom fdl domain (#2121) ...
No description provided.