Skip to content

Carthage instructions for new gRPCCertificates.bundle location #2132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2018
Merged

Carthage instructions for new gRPCCertificates.bundle location #2132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Carthage.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ binary "https://dl.google.com/dl/firebase/ios/carthage/FirebaseStorageBinary.jso
into the Xcode project and make sure they're added to the
`Copy Bundle Resources` Build Phase :
- For Firestore:
- ./Carthage/Build/iOS/gRPC.framework/gRPCCertificates.bundle
- ./Carthage/Build/iOS/FirebaseFirestore.framework/gRPCCertificates.bundle
- For Invites:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulb777 Sorry I didn't think about it earlier: I have renamed the bundle in Firestore to gRPCCertificates-Firestore specifically to avoid the name clash with gRPC. I downloaded the latest Carthage zip file, and it looks like it has the bundle named gRPCCertificates.bundle, not gRPCCertificates-Firestore.bundle. So for that zip file, these instructions would work. However, I'm not sure why the older bundle name is used.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@var-const The Carthage distribution is created from the zip distribution which also doesn't have the rename:

screen shot 2018-11-29 at 10 30 18 am

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I guess the distribution was created from a commit older than #2106. As long as the code and the bundle name are in sync, everything should be fine. I'll update the instructions again (to account for the renaming) before the next release.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right #2106 is not in https://github.com/firebase/firebase-ios-sdk/commits/release-5.13.0.

Thanks!

- ./Carthage/Build/iOS/FirebaseInvites.framework/GoogleSignIn.bundle
- ./Carthage/Build/iOS/FirebaseInvites.framework/GPPACLPickerResources.bundle
Expand Down