C++ migration: port FSTTargetChange
#2318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zxu123
approved these changes
Jan 28, 2019
rsgowman
approved these changes
Jan 29, 2019
| if (targetChange) { | ||
| for (const DocumentKey &key : targetChange.addedDocuments) { | ||
| - (void)applyTargetChange:(const absl::optional<TargetChange> &)maybeTargetChange { | ||
| if (maybeTargetChange.has_value()) { |
There was a problem hiding this comment.
This is fine (and is exactly as previous). You could reverse the if statement to eliminate a level of indentation, i.e.:
if (!...) return;
...
Very optional.
There was a problem hiding this comment.
I would also prefer an early return, but other platforms follow this pattern as well. I'd rather leave as is for consistency.
| modifiedDocuments:modified | ||
| removedDocuments:removed]; | ||
| TargetChange FSTTestTargetChangeMarkCurrent() { | ||
| return {[NSData data], true, DocumentKeySet{}, DocumentKeySet{}, DocumentKeySet{}}; |
There was a problem hiding this comment.
Consider adding named parameters for the bool and DocKeySet params. Also immediately below. Optional.
(Possibly more useful for the one below. Here, I don't know which docKeySet is which, but it doesn't matter since they're all defaulted.)
bstpierr
added a commit
that referenced
this pull request
Feb 8, 2019
* master: (27 commits) Pass FSTMutations using a vector (#2357) Update CI to use CocoaPods 1.6.0 (#2360) Add NS_ASSUME_NONNULL_NOTATION for game center sign in (#2359) C++ migration: make all methods of `FSTRemoteStore` delegate to C++ (#2337) C++ migration: port write stream-related part of `FSTRemoteStore` (#2335) Resolve hard dependency of GameKit (#2355) Update gRPC certificate bundles locations for Firebase 5.16 (#2353) Start pod lib lint CI for IAM (#2347) Update library name to `fire-fiam`. (#2352) Bump FirebaseAnalyticsInterop version (#2315) Add IAM headless to CI (#2341) C++ migration: port watch stream-related part of `FSTRemoteStore` (#2331) Open source FIAM headless SDK (#2312) Port flaky test fix from web. (#2332) Make scripts/style.sh compatible with newer swiftformat versions (0.38) (#2334) C++ migration: port `FSTOnlineStateTracker` (#2325) Don't build fuzz tests target on Travis (#2330) Remove FSTMutationQueue (#2319) C++ migration: port `FSTRemoteEvent` (#2320) C++ migration: port `FSTTargetChange` (#2318) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.