Code

C++ migration: port FSTTargetChange#2318

Code

Merged

var-const merged 71 commits intomasterfirebase/firebase-ios-sdk:masterfrom

varconst/fst-target-changefirebase/firebase-ios-sdk:varconst/fst-target-changeCopy head branch name to clipboard

Jan 29, 2019

Commits

Commits on Jan 15, 2019

• Remove extra imports and includes

  var-const

  committed
  76b206b

  Copy full SHA for 76b206b

• Port

  var-const

  committed
  7dcb9ae

  Copy full SHA for 7dcb9ae

• Forgotten method

  var-const

  committed
  88ba1a7

  Copy full SHA for 88ba1a7

• style.sh

  var-const

  committed
  895bf45

  Copy full SHA for 895bf45

• Forgotten the main part!

  var-const

  committed
  b66c5d2

  Copy full SHA for b66c5d2

• Fixup unit tests

  var-const

  committed
  3f5fdae

  Copy full SHA for 3f5fdae

Commits on Jan 16, 2019

• Wip

  var-const

  committed
  5ce04b8

  Copy full SHA for 5ce04b8

Commits on Jan 18, 2019

• Step back

  var-const

  committed
  3dc3170

  Copy full SHA for 3dc3170

• Core compiles

  var-const

  committed
  9d1f931

  Copy full SHA for 9d1f931

• Merge branch 'master' into varconst/fst-watch-change

  var-const

  committed
  7ea798e

  Copy full SHA for 7ea798e

• quick fix

  var-const

  committed
  84842be

  Copy full SHA for 84842be

• Test helpers

  var-const

  committed
  e5132be

  Copy full SHA for e5132be

• MockDatastore

  var-const

  committed
  6c85090

  Copy full SHA for 6c85090

• FSTLocalStoreTests

  var-const

  committed
  f7a90b5

  Copy full SHA for f7a90b5

• wip

  var-const

  committed
  267963f

  Copy full SHA for 267963f

• wip

  var-const

  committed
  60a5726

  Copy full SHA for 60a5726

• FSTRemoveEventTests

  var-const

  committed
  dd9d98d

  Copy full SHA for dd9d98d

Commits on Jan 19, 2019

• FSTSerializerBetaTests

  var-const

  committed
  aec3f54

  Copy full SHA for aec3f54

• wip

  var-const

  committed
  b012929

  Copy full SHA for b012929

Commits on Jan 21, 2019

• wip

  var-const

  committed
  1da0672

  Copy full SHA for 1da0672

• wip

  var-const

  committed
  e0f77f2

  Copy full SHA for e0f77f2

• wip

  var-const

  committed
  df5cd00

  Copy full SHA for df5cd00

• wip

  var-const

  committed
  5d3313a

  Copy full SHA for 5d3313a

• wip

  var-const

  committed
  31e5f3d

  Copy full SHA for 31e5f3d

• Ship it!

  var-const

  committed
  0637243

  Copy full SHA for 0637243

• use changes

  var-const

  committed
  26b39c7

  Copy full SHA for 26b39c7

• quick fix

  var-const

  committed
  2cab650

  Copy full SHA for 2cab650

• Unit tests pass

  var-const

  committed
  ca88d8c

  Copy full SHA for ca88d8c

• style.sh

  var-const

  committed
  2c0a7ef

  Copy full SHA for 2c0a7ef

• Small fixes

  var-const

  committed
  52b131d

  Copy full SHA for 52b131d

• Get rid of ids alias

  var-const

  committed
  35ce8cc

  Copy full SHA for 35ce8cc

• Fixes

  var-const

  committed
  8230fbb

  Copy full SHA for 8230fbb

• Move the test

  var-const

  committed
  ceb3bee

  Copy full SHA for ceb3bee

• Restore nooutstandingresponses variable

  var-const

  committed
  dd617de

  Copy full SHA for dd617de

• Small fixes

  var-const

  committed
  9d80eea

  Copy full SHA for 9d80eea

• style.sh

  var-const

  committed
  836d4de

  Copy full SHA for 836d4de

Commits on Jan 22, 2019

• Review feedback

  var-const

  committed
  134acaf

  Copy full SHA for 134acaf

• Review feedback

  var-const

  committed
  f8dd5a5

  Copy full SHA for f8dd5a5

• comment

  var-const

  committed
  c02df53

  Copy full SHA for c02df53

• Appease linter

  var-const

  committed
  ce17913

  Copy full SHA for ce17913

• Initial

  var-const

  committed
  a87cf7e

  Copy full SHA for a87cf7e

Commits on Jan 23, 2019

• wip

  var-const

  committed
  d6a137a

  Copy full SHA for d6a137a

• wip

  var-const

  committed
  1c99679

  Copy full SHA for 1c99679

• Initial

  var-const

  committed
  b2e0dd1

  Copy full SHA for b2e0dd1

• style.sh

  var-const

  committed
  e076f25

  Copy full SHA for e076f25

• Merge branch 'master' into varconst/fst-document-view-change-type

  var-const

  committed
  359d938

  Copy full SHA for 359d938

• forgotten file

  var-const

  committed
  4b7c6a7

  Copy full SHA for 4b7c6a7

• Merge branch 'varconst/fst-document-view-change-type' into varconst/fst-watch-change-aggregator

  var-const

  committed
  7164e2b

  Copy full SHA for 7164e2b

• pt. 1 compiles

  var-const

  committed
  48fbab6

  Copy full SHA for 48fbab6

• Wip

  var-const

  committed
  0325248

  Copy full SHA for 0325248

Commits on Jan 24, 2019

• wip

  var-const

  committed
  acbc626

  Copy full SHA for acbc626

• Merge branch 'master' into varconst/fst-watch-change-aggregator

  var-const

  committed
  b178b00

  Copy full SHA for b178b00

• In theory, all methods implemented

  var-const

  committed
  78395d8

  Copy full SHA for 78395d8

• wip

  var-const

  committed
  4fee491

  Copy full SHA for 4fee491

• Almost compiles

  var-const

  committed
  626efec

  Copy full SHA for 626efec

• Merge branch 'master' into varconst/fst-watch-change-aggregator

  var-const

  committed
  66db96a

  Copy full SHA for 66db96a

• appease linter

  var-const

  committed
  d5defb1

  Copy full SHA for d5defb1

• Bring method order into compliance

  var-const

  committed
  52b2171

  Copy full SHA for 52b2171

• Compliacne, pt.2

  var-const

  committed
  e5fcf94

  Copy full SHA for e5fcf94

Commits on Jan 25, 2019

• core compiles

  var-const

  committed
  7a48512

  Copy full SHA for 7a48512

Commits on Jan 26, 2019

• unit tests compile

  var-const

  committed
  66d8af2

  Copy full SHA for 66d8af2

• Fix unit test -- all pass

  var-const

  committed
  594a841

  Copy full SHA for 594a841

• style.sh

  var-const

  committed
  77d9cd7

  Copy full SHA for 77d9cd7

• Review feedback

  var-const

  committed
  fdf05a7

  Copy full SHA for fdf05a7

• Merge branch 'varconst/fst-watch-change-aggregator' into varconst/fst-target-change

  var-const

  committed
  a910ccd

  Copy full SHA for a910ccd

• undo formatting

  var-const

  committed
  c71a541

  Copy full SHA for c71a541

• fix

  var-const

  committed
  24a745e

  Copy full SHA for 24a745e

Commits on Jan 27, 2019

• Merge branch 'varconst/fst-watch-change-aggregator' into varconst/fst-target-change

  var-const

  committed
  142f08c

  Copy full SHA for 142f08c

• Merge branch 'master' into varconst/fst-target-change

  var-const

  committed
  e402e8b

  Copy full SHA for e402e8b

• Temp code

  var-const

  committed
  e3dd85e

  Copy full SHA for e3dd85e

Commits on Jan 29, 2019

• Review feedback

  var-const

  committed
  766e940

  Copy full SHA for 766e940