Enable code coverage locally #2400
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is for #793. Next step will be hooking up to Travis. |
* Fix import references to other pod's headers to fix pod lib lint * style * fiam travis config fixes * Fix Sample's HEADER_SEARCH_PATHS
paulb777
requested changes
Feb 21, 2019
There was a problem hiding this comment.
After following the instructions, when I open the html file, I only see Core and Database files. I suspect it doesn't handle aggregate Xcode test targets.
Perhaps, instead the instructions should be changing the scheme to enable coverage on an individual test target and running that one?
* Update versions for Release 5.17.0 * Fix the tag in the FIAM podspec. * Update dependencies for FIAM. * Updated the FirebaseCore version. * Fix FIROptions version. * Temporarily remove FIAM version deps for pod linting. * Create umbrella header for FIAM (#2392) This causes an issue when building the zip file - similar to #1857 * Remove FIAM from 5.17.0 release.
* Step 1: Duplicate ASL Logger This copies over the ASL logging system to a standalone Objective-C class. * Step 2: Replace Logger with ObjC Implementation This also moved the `forcedDebug` information to a property. * Step 3: Remove unnecessary test methods It does not seem necessary to drain the queue. If this is an issue on a platform I didn't test, we should implement the tests differently, such that surfacing the queue is not necessary. * Style Fixes * Test cleanup * Removed FIRLoggerTest as they mostly actually test `GULASLLogger` functionality now. * Renamed `GULLoggerInitializeASL` to `GULLoggerInitialize`. * Use dot-notation for the defaultLogger class property. * Removed unused debug only test methods. * Rename FIRLoggerInitializeASL * Style fixes * ASL Logger cleanup and leaking * Move ivar synthesis to the top of the implementation. * Add dealloc logic to avoid leaking asl_obj memory. * Add forced logic at the message level. * GULLogger Testing * Moved over old tests to correct ASLLogger location. * Added new GULLogger tests * Changed version `char *` to `NSString *` * Tidied up some documentation * Re-introduce ASL in the functions names * os_log GULLogger Implementation * Moved common logic from `GULASLLogger` to `GULLogger+Internal` class methods. * Added `os_log` implementation of `GULLoggerSystem` * Added `os_log` level information to `GULLoggerLevel` * Removed unused test variable TODO: Tests * Remove iOS version check from ASLLogger * Style Fixes * Refer to ivar directly in property setter * Refer to ivar directly in property setter * Being os_log tests * Setup dependency injection for os_log tests * Rename C functions according to style and correctly test macOS version compatibility * Further refinement of os_log testing * Add Some OSLogger tests and update some ASLLogger ones * Re-add getter for logLevel * Fix up some warnings * Remove private headers from local testing podspec * More OSLogger tests & bug fixes * Style Fixes * Fix Travis build * Update GULOSLoggerTest.m * Do nt override method argument * Fix test on tvOS * Test Fixes * Copybara test fixes * PR Feedback
* Run Firestore builds/tests on GoogleUtilities changes * Silence macOS 10.10 warnings * Add cast to fix Firestore macOS builds
* pod deintegrate fiam sample proj to work with both cp 1.6.0 and 1.6.1
Changes the default timeout for FirebaseFunctions to 70s and adds an API to override that timeout on a per-function basis.
* FIRStorageUploadTask: validate data and fileURL before upload (#2350) * FIRStorageReferenceTests: Verify a specific error (#2350) * Code cleanup. More informative error. * FIRStorageReference: error message, test fix (#2350) * Run ./scripts/style.sh * #2350: Punctuation * FIRStorageReferenceTests: naming (#2350) * Run ./scripts/style.sh * Tests fixed (#2350) * FIRStorageReferenceTests fixed for Mac OS (#2350) * FIRStorageUploadTask: validate content just before uploading (#2350)
* Compatible value for ll testing on 32 and 64 bit targets
Ports an optimization from Android where we skip parsing documents that are in subcollections beneath the collection we're querying over.
* Introduce tooling to build the Zip file. * Cleanup to prepare for review. This moves argument parsing into its own file, moves some methods into CocoaPodUtils and consolidates some related types. * Add modulemap and Firebase.h * Adding CoreDiagnostics, WIP * Refactored paths into separate struct. * Organized methods. * Remove unused utility import. * Properly passed in custom spec repos. * Added licenses, outputDir argument. * Fix the Zip command to use the working directory. * Fixing bundles and headers being copied. * Fixing the resources directories. * More iterations to come closer to Released zip. - Fixed the caching of OSS pods - Add custom Crash objects - Move resources around properly. * Missing comment. * Fix resources for MLKit and others. * Remove unused URL extension. * Add priorities to README, exclude Firebase.framework * Run style.sh * Fully ran style.sh * Add license to files that don't have it. * Address feedback from first review. * Add missing custom spec repo flag.
…2473) Also avoid static FieldValues since they're not trivially destructible. https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables
Now that Apple requires Xcode 10.1+ to submit to the App Store, we can package the Zip file using Xcode 10.1.
… into enableCoverage
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
|
Whoops I think I messed up the PR when trying to rebase with the fixes. I think it'll be easiest to create a new one from scratch (my git mojo isn't too good :). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables code coverage collection and provides instructions to view results.