Skip to content

Minimal fix for b/74357976. #890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 8, 2018
Merged

Minimal fix for b/74357976. #890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1614b5a
Minimal fix for b/74357976
Mar 8, 2018
1c94cc3
Update changelog.
Mar 8, 2018
3b4fa32
Tweak changelog message to cover additional symptom due to util::Wrap…
Mar 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Firestore/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# Unreleased

# v0.10.3
- [fixed] Fixed a regression in the 4.10.0 Firebase iOS SDK release that
prevented the SDK from communicating with the backend before successfully
authenticating via Firebase Authentication or after unauthenticating and
re-authenticating. Reads and writes would silently be executed locally
but not sent to the backend.

# v0.10.2
- [changed] When you delete a FirebaseApp, the associated Firestore instances
are now also deleted (#683).
Expand Down
2 changes: 1 addition & 1 deletion Firestore/Source/Remote/FSTDatastore.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ - (void)invokeRPCWithFactory:(GRPCProtoCall * (^)(void))rpcFactory
[FSTDatastore
prepareHeadersForRPC:rpc
databaseID:&self.databaseInfo->database_id()
token:(result.is_valid() ? result.token()
token:(result.user().is_authenticated() ? result.token()
: absl::string_view())];
[rpc start];
}
Expand Down
2 changes: 1 addition & 1 deletion Firestore/Source/Remote/FSTStream.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ - (void)resumeStartWithToken:(const Token &)token error:(NSError *)error {

[FSTDatastore prepareHeadersForRPC:_rpc
databaseID:&self.databaseInfo->database_id()
token:(token.is_valid() ? token.token() : absl::string_view())];
token:(token.user().is_authenticated() ? token.token() : absl::string_view())];
FSTAssert(_callbackFilter == nil, @"GRX Filter must be nil");
_callbackFilter = [[FSTCallbackFilter alloc] initWithStream:self];
[_rpc startWithWriteable:_callbackFilter];
Expand Down