Minimal fix for b/74357976. #890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilhuff
approved these changes
Mar 8, 2018
|
Oh also, changelog |
zxu123
reviewed
Mar 8, 2018
|
Good call, added changelog entry. |
|
I made a release-4.10.1 branch. Please target it there. |
paulb777
previously requested changes
Mar 8, 2018
|
I've changed the target branch, but we're looking into an additional (perhaps related issue) so may want to hold off on merging this. |
mikelehen
changed the title
|
Okay, I've incorporated the second fix that @wilhuff tracked down. PTAL |
|
Actually @wilhuff is doing a further audit of WrapNSStringNoCopy() usages for additional potential bugs... |
…NSStringNoCopy() issue which @wilhuff is going to create a fix for.
mikelehen
force-pushed
the
mikelehen/fix-unauthenticated-access-minimal
branch
from
37073b6 to
3b4fa32
Compare
|
@wilhuff is going to create a separate PR for all of the util:WrapNSStringNoCopy() fixes. This PR will just be for the original token issue and should be good-to-go now. |
morganchen12
approved these changes
Mar 8, 2018
There was a problem hiding this comment.
Approving on @paulb777's behalf, since this PR is now targeting the correct branch.
morganchen12
dismissed
paulb777’s stale review
Paul briefly unavailable--see review comment
paulb777
approved these changes
Mar 8, 2018
wilhuff
changed the title
zxu123
added a commit
that referenced
this pull request
Mar 9, 2018
* Version bumps for Firebase 4.10.1 (#891) * Minimal fix for b/74357976 (#890) Fixes b/74357976 which caused unauthenticated users to be unable to reach the Firestore backend and updates the changelog. * Copy all C++ strings to NSString where they're not obviously safe (#893) This fixes a known instances of memory corruption where in FSTLevelDBMutationQueue, the NSString view was retained for later, and the incorrect user was used, causing b/74381054. gRPC does not necessarily copy its string argumnets and if our hostname were configured to a non-default one it's possible that we could corrupt the host cache too. All remaining usages of util::WrapNSStringNoCopy are obviously safe: passed into logging or other known transient usages. * fix lint
minafarid
pushed a commit
to minafarid/firebase-ios-sdk
that referenced
this pull request
Jun 6, 2018
Fixes b/74357976 which caused unauthenticated users to be unable to reach the Firestore backend and updates the changelog.
minafarid
pushed a commit
to minafarid/firebase-ios-sdk
that referenced
this pull request
Jun 6, 2018
* Version bumps for Firebase 4.10.1 (firebase#891) * Minimal fix for b/74357976 (firebase#890) Fixes b/74357976 which caused unauthenticated users to be unable to reach the Firestore backend and updates the changelog. * Copy all C++ strings to NSString where they're not obviously safe (firebase#893) This fixes a known instances of memory corruption where in FSTLevelDBMutationQueue, the NSString view was retained for later, and the incorrect user was used, causing b/74381054. gRPC does not necessarily copy its string argumnets and if our hostname were configured to a non-default one it's possible that we could corrupt the host cache too. All remaining usages of util::WrapNSStringNoCopy are obviously safe: passed into logging or other known transient usages. * fix lint
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a more minimal alternative to #887.