Skip to content

Cpp/fix auth token string nocopy #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Cpp/fix auth token string nocopy #894

wants to merge 2 commits into from

Conversation

zxu123
Copy link
Contributor

@zxu123 zxu123 commented Mar 8, 2018

Patch of fix #893 and #890 to master

  • Copy all C++ strings to NSString where they're not obviously safe.
  • Minimal fix for b/74357976.

@zxu123 zxu123 requested review from mikelehen and wilhuff March 8, 2018 21:18
wilhuff
wilhuff suggested changes Mar 8, 2018
View reviewed changes
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way we normally handle this is to merge from the release branch into master; we shouldn't have to cherry-pick these changes.

Here's an example for the prior release:

#880

@wilhuff
Copy link
Contributor

wilhuff commented Mar 9, 2018

We've already merged to master via #895 and #901 so this PR is no longer necessary, right?

@wilhuff wilhuff closed this Mar 9, 2018
@zxu123 zxu123 deleted the cpp/fix_auth_token_string_nocopy branch March 13, 2018 18:22
@firebase firebase locked and limited conversation to collaborators Nov 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikelehen mikelehen Awaiting requested review from mikelehen

1 more reviewer

@wilhuff wilhuff wilhuff requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
api: firestore cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zxu123 @wilhuff @googlebot