Skip to content

VinF Hybrid Inference: Define Availability values #8951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2025

Conversation

erikeldridge
Copy link

LanguageModel.availability() returns Availability in TS, but a string in JS, causing the comparison to fail. Since we define the TS types for LanguageModel (for now, at least), we can define string values for the Availability enum, which enables the comparison to work as expected.

@erikeldridge erikeldridge requested a review from a team as a code owner April 21, 2025 19:06
Copy link

changeset-bot bot commented Apr 21, 2025

⚠️ No Changeset found

Latest commit: 1cc346f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v10.0

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • @firebase/vertexai

    TypeBase (3d7df8b)Merge (482a1a5)Diff
    browser39.2 kB39.1 kB-64 B (-0.2%)
    main40.2 kB40.1 kB-64 B (-0.2%)
    module39.2 kB39.1 kB-64 B (-0.2%)
  • firebase

    TypeBase (3d7df8b)Merge (482a1a5)Diff
    firebase-vertexai.js31.4 kB31.4 kB-20 B (-0.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Awjxlta9Pl.html

@google-oss-bot
Copy link
Contributor

Size Analysis Report 1

Affected Products

  • @firebase/vertexai

    • ArraySchema

      Size

      TypeBase (3d7df8b)Merge (482a1a5)Diff
      size5.67 kB5.65 kB-20 B (-0.4%)
      size-with-ext-deps23.6 kB23.6 kB-20 B (-0.1%)
    • BlockReason

      Size

      TypeBase (3d7df8b)Merge (482a1a5)Diff
      size3.58 kB3.56 kB-20 B (-0.6%)
      size-with-ext-deps21.5 kB21.5 kB-20 B (-0.1%)
    • BooleanSchema

      Size

      TypeBase (3d7df8b)Merge (482a1a5)Diff
      size5.68 kB5.66 kB-20 B (-0.4%)
      size-with-ext-deps23.6 kB23.6 kB-20 B (-0.1%)
    • ChatSession

      Size

      TypeBase (3d7df8b)Merge (482a1a5)Diff
      size16.3 kB16.2 kB-20 B (-0.1%)
      size-with-ext-deps35.2 kB35.2 kB-20 B (-0.1%)
    • FinishReason

      Size

      TypeBase (3d7df8b)Merge (482a1a5)Diff
      size3.58 kB3.56 kB-20 B (-0.6%)
      size-with-ext-deps21.5 kB21.5 kB-20 B (-0.1%)
    • FunctionCallingMode

      Size

      TypeBase (3d7df8b)Merge (482a1a5)Diff
      size3.59 kB3.57 kB-20 B (-0.6%)
      size-with-ext-deps21.5 kB21.5 kB-20 B (-0.1%)
    • GenerativeModel

      Size

      TypeBase (3d7df8b)Merge (482a1a5)Diff
      size19.6 kB19.6 kB-20 B (-0.1%)
      size-with-ext-deps38.6 kB38.6 kB-20 B (-0.1%)
    • HarmBlockMethod

      Size

      TypeBase (3d7df8b)Merge (482a1a5)Diff
      size3.59 kB3.57 kB-20 B (-0.6%)
      size-with-ext-deps21.5 kB21.5 kB-20 B (-0.1%)
    • HarmBlockThreshold

      Size

      TypeBase (3d7df8b)Merge (482a1a5)Diff
      size3.59 kB3.57 kB-20 B (-0.6%)
      size-with-ext-deps21.5 kB21.5 kB-20 B (-0.1%)
    • HarmCategory

      Size

      TypeBase (3d7df8b)Merge (482a1a5)Diff
      size3.58 kB3.56 kB-20 B (-0.6%)
      size-with-ext-deps21.5 kB21.5 kB-20 B (-0.1%)
    • HarmProbability

      Size

      TypeBase (3d7df8b)Merge (482a1a5)Diff
      size3.59 kB3.57 kB-20 B (-0.6%)
      size-with-ext-deps21.5 kB21.5 kB-20 B (-0.1%)
    • HarmSeverity

      Size

      TypeBase (3d7df8b)Merge (482a1a5)Diff
      size3.58 kB3.56 kB-20 B (-0.6%)
      size-with-ext-deps21.5 kB21.5 kB-20 B (-0.1%)
    • ImagenAspectRatio

      Size

      TypeBase (3d7df8b)Merge (482a1a5)Diff
      size3.59 kB3.57 kB-20 B (-0.6%)
      size-with-ext-deps21.5 kB21.5 kB-20 B (-0.1%)
    • ImagenImageFormat

      Size

      TypeBase (3d7df8b)Merge (482a1a5)Diff
      size3.87 kB3.85 kB-20 B (-0.5%)
      size-with-ext-deps21.8 kB21.8 kB-20 B (-0.1%)
    • ImagenModel

      Size

      TypeBase (3d7df8b)Merge (482a1a5)Diff
      size21.4 kB21.4 kB-20 B (-0.1%)
      size-with-ext-deps40.4 kB40.4 kB-20 B (-0.0%)
    • ImagenPersonFilterLevel

      Size

      TypeBase (3d7df8b)Merge (482a1a5)Diff
      size3.60 kB3.58 kB-20 B (-0.6%)
      size-with-ext-deps21.5 kB21.5 kB-20 B (-0.1%)
    • ImagenSafetyFilterLevel

      Size

      TypeBase (3d7df8b)Merge (482a1a5)Diff
      size3.60 kB3.58 kB-20 B (-0.6%)
      size-with-ext-deps21.5 kB21.5 kB-20 B (-0.1%)
    • IntegerSchema

      Size

      TypeBase (3d7df8b)Merge (482a1a5)Diff
      size5.68 kB5.66 kB-20 B (-0.4%)
      size-with-ext-deps23.6 kB23.6 kB-20 B (-0.1%)
    • Modality

      Size

      TypeBase (3d7df8b)Merge (482a1a5)Diff
      size3.58 kB3.56 kB-20 B (-0.6%)
      size-with-ext-deps21.5 kB21.5 kB-20 B (-0.1%)
    • NumberSchema

      Size

      TypeBase (3d7df8b)Merge (482a1a5)Diff
      size5.67 kB5.65 kB-20 B (-0.4%)
      size-with-ext-deps23.6 kB23.6 kB-20 B (-0.1%)
    • ObjectSchema

      Size

      TypeBase (3d7df8b)Merge (482a1a5)Diff
      size5.67 kB5.65 kB-20 B (-0.4%)
      size-with-ext-deps23.6 kB23.6 kB-20 B (-0.1%)
    • POSSIBLE_ROLES

      Size

      TypeBase (3d7df8b)Merge (482a1a5)Diff
      size3.63 kB3.61 kB-20 B (-0.6%)
      size-with-ext-deps21.5 kB21.5 kB-20 B (-0.1%)
    • Schema

      Size

      TypeBase (3d7df8b)Merge (482a1a5)Diff
      size5.67 kB5.65 kB-20 B (-0.4%)
      size-with-ext-deps23.6 kB23.6 kB-20 B (-0.1%)
    • SchemaType

      Size

      TypeBase (3d7df8b)Merge (482a1a5)Diff
      size3.58 kB3.56 kB-20 B (-0.6%)
      size-with-ext-deps21.5 kB21.5 kB-20 B (-0.1%)
    • StringSchema

      Size

      TypeBase (3d7df8b)Merge (482a1a5)Diff
      size5.67 kB5.65 kB-20 B (-0.4%)
      size-with-ext-deps23.6 kB23.6 kB-20 B (-0.1%)
    • VertexAIError

      Size

      TypeBase (3d7df8b)Merge (482a1a5)Diff
      size3.89 kB3.87 kB-20 B (-0.5%)
      size-with-ext-deps21.8 kB21.8 kB-20 B (-0.1%)
    • VertexAIModel

      Size

      TypeBase (3d7df8b)Merge (482a1a5)Diff
      size19.6 kB19.6 kB-20 B (-0.1%)
      size-with-ext-deps38.6 kB38.6 kB-20 B (-0.1%)
    • getGenerativeModel

      Size

      TypeBase (3d7df8b)Merge (482a1a5)Diff
      size22.2 kB22.2 kB-20 B (-0.1%)
      size-with-ext-deps41.2 kB41.2 kB-20 B (-0.0%)
    • getImagenModel

      Size

      TypeBase (3d7df8b)Merge (482a1a5)Diff
      size21.6 kB21.5 kB-20 B (-0.1%)
      size-with-ext-deps40.5 kB40.5 kB-20 B (-0.0%)
    • getVertexAI

      Size

      TypeBase (3d7df8b)Merge (482a1a5)Diff
      size3.76 kB3.74 kB-20 B (-0.5%)
      size-with-ext-deps29.0 kB29.0 kB-20 B (-0.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/up0Vt2oWOi.html

@erikeldridge
Copy link
Author

"Test Modified Packages / Test Packages With Changed Files in Webkit (pull_request)" doesn't seem obviously Firestore- or Auth-related, but IIUC, the failure also doesn't seem VinF-related:

lerna ERR! yarn run test:ci exited 1 in '@firebase/data-connect'

Given the above, I'll go ahead and merge.

@erikeldridge erikeldridge merged commit 622916c into vaihi-exp Apr 21, 2025
29 of 45 checks passed
@erikeldridge erikeldridge deleted the erikeldridge-vertex-availability branch April 21, 2025 22:16
gsiddh pushed a commit that referenced this pull request Apr 22, 2025
gsiddh pushed a commit that referenced this pull request Apr 22, 2025
gsiddh pushed a commit that referenced this pull request Apr 23, 2025
Fix languageCode parameter in action_code_url (#8912)

* Fix languageCode parameter in action_code_url

* Add changeset

Vaihi add langmodel types. (#8927)

* Adding LanguageModel types. These are based off https://github.com/webmachinelearning/prompt-api?tab=readme-ov-file#full-api-surface-in-web-idl

* Adding LanguageModel types.

* Remove bunch of exports

* yarn formatted

* after lint

Define HybridParams (#8935)

Co-authored-by: Erik Eldridge <[email protected]>

Adding smoke test for new hybrid params (#8937)

* Adding smoke test for new hybrid params

* Use the existing name of the model params input

---------

Co-authored-by: Erik Eldridge <[email protected]>

Moving to in-cloud naming (#8938)

Co-authored-by: Erik Eldridge <[email protected]>

Moving to string type for the inference mode (#8941)

Define ChromeAdapter class (#8942)

Co-authored-by: Erik Eldridge <[email protected]>

VinF Hybrid Inference: Implement ChromeAdapter (rebased) (#8943)

Adding count token impl (#8950)

VinF Hybrid Inference #4: ChromeAdapter in stream methods (rebased) (#8949)

Define values for Availability enum (#8951)

VinF Hybrid Inference: narrow Chrome input type (#8953)

Add image inference support (#8954)

* Adding image based input for inference

* adding image as input to create language model object

disable count tokens api for on-device inference (#8962)

VinF Hybrid Inference: throw if only_on_device and model is unavailable (#8965)
gsiddh pushed a commit that referenced this pull request Apr 23, 2025
Fix languageCode parameter in action_code_url (#8912)

* Fix languageCode parameter in action_code_url

* Add changeset

Vaihi add langmodel types. (#8927)

* Adding LanguageModel types. These are based off https://github.com/webmachinelearning/prompt-api?tab=readme-ov-file#full-api-surface-in-web-idl

* Adding LanguageModel types.

* Remove bunch of exports

* yarn formatted

* after lint

Define HybridParams (#8935)

Co-authored-by: Erik Eldridge <[email protected]>

Adding smoke test for new hybrid params (#8937)

* Adding smoke test for new hybrid params

* Use the existing name of the model params input

---------

Co-authored-by: Erik Eldridge <[email protected]>

Moving to in-cloud naming (#8938)

Co-authored-by: Erik Eldridge <[email protected]>

Moving to string type for the inference mode (#8941)

Define ChromeAdapter class (#8942)

Co-authored-by: Erik Eldridge <[email protected]>

VinF Hybrid Inference: Implement ChromeAdapter (rebased) (#8943)

Adding count token impl (#8950)

VinF Hybrid Inference #4: ChromeAdapter in stream methods (rebased) (#8949)

Define values for Availability enum (#8951)

VinF Hybrid Inference: narrow Chrome input type (#8953)

Add image inference support (#8954)

* Adding image based input for inference

* adding image as input to create language model object

disable count tokens api for on-device inference (#8962)

VinF Hybrid Inference: throw if only_on_device and model is unavailable (#8965)
gsiddh pushed a commit that referenced this pull request Apr 23, 2025
Fix languageCode parameter in action_code_url (#8912)

* Fix languageCode parameter in action_code_url

* Add changeset

Vaihi add langmodel types. (#8927)

* Adding LanguageModel types. These are based off https://github.com/webmachinelearning/prompt-api?tab=readme-ov-file#full-api-surface-in-web-idl

* Adding LanguageModel types.

* Remove bunch of exports

* yarn formatted

* after lint

Define HybridParams (#8935)

Co-authored-by: Erik Eldridge <[email protected]>

Adding smoke test for new hybrid params (#8937)

* Adding smoke test for new hybrid params

* Use the existing name of the model params input

---------

Co-authored-by: Erik Eldridge <[email protected]>

Moving to in-cloud naming (#8938)

Co-authored-by: Erik Eldridge <[email protected]>

Moving to string type for the inference mode (#8941)

Define ChromeAdapter class (#8942)

Co-authored-by: Erik Eldridge <[email protected]>

VinF Hybrid Inference: Implement ChromeAdapter (rebased) (#8943)

Adding count token impl (#8950)

VinF Hybrid Inference #4: ChromeAdapter in stream methods (rebased) (#8949)

Define values for Availability enum (#8951)

VinF Hybrid Inference: narrow Chrome input type (#8953)

Add image inference support (#8954)

* Adding image based input for inference

* adding image as input to create language model object

disable count tokens api for on-device inference (#8962)

VinF Hybrid Inference: throw if only_on_device and model is unavailable (#8965)
gsiddh pushed a commit that referenced this pull request Apr 23, 2025
Fix languageCode parameter in action_code_url (#8912)

* Fix languageCode parameter in action_code_url

* Add changeset

Vaihi add langmodel types. (#8927)

* Adding LanguageModel types. These are based off https://github.com/webmachinelearning/prompt-api?tab=readme-ov-file#full-api-surface-in-web-idl

* Adding LanguageModel types.

* Remove bunch of exports

* yarn formatted

* after lint

Define HybridParams (#8935)

Co-authored-by: Erik Eldridge <[email protected]>

Adding smoke test for new hybrid params (#8937)

* Adding smoke test for new hybrid params

* Use the existing name of the model params input

---------

Co-authored-by: Erik Eldridge <[email protected]>

Moving to in-cloud naming (#8938)

Co-authored-by: Erik Eldridge <[email protected]>

Moving to string type for the inference mode (#8941)

Define ChromeAdapter class (#8942)

Co-authored-by: Erik Eldridge <[email protected]>

VinF Hybrid Inference: Implement ChromeAdapter (rebased) (#8943)

Adding count token impl (#8950)

VinF Hybrid Inference #4: ChromeAdapter in stream methods (rebased) (#8949)

Define values for Availability enum (#8951)

VinF Hybrid Inference: narrow Chrome input type (#8953)

Add image inference support (#8954)

* Adding image based input for inference

* adding image as input to create language model object

disable count tokens api for on-device inference (#8962)

VinF Hybrid Inference: throw if only_on_device and model is unavailable (#8965)
gsiddh pushed a commit that referenced this pull request Apr 23, 2025
Fix languageCode parameter in action_code_url (#8912)

* Fix languageCode parameter in action_code_url

* Add changeset

Vaihi add langmodel types. (#8927)

* Adding LanguageModel types. These are based off https://github.com/webmachinelearning/prompt-api?tab=readme-ov-file#full-api-surface-in-web-idl

* Adding LanguageModel types.

* Remove bunch of exports

* yarn formatted

* after lint

Define HybridParams (#8935)

Co-authored-by: Erik Eldridge <[email protected]>

Adding smoke test for new hybrid params (#8937)

* Adding smoke test for new hybrid params

* Use the existing name of the model params input

---------

Co-authored-by: Erik Eldridge <[email protected]>

Moving to in-cloud naming (#8938)

Co-authored-by: Erik Eldridge <[email protected]>

Moving to string type for the inference mode (#8941)

Define ChromeAdapter class (#8942)

Co-authored-by: Erik Eldridge <[email protected]>

VinF Hybrid Inference: Implement ChromeAdapter (rebased) (#8943)

Adding count token impl (#8950)

VinF Hybrid Inference #4: ChromeAdapter in stream methods (rebased) (#8949)

Define values for Availability enum (#8951)

VinF Hybrid Inference: narrow Chrome input type (#8953)

Add image inference support (#8954)

* Adding image based input for inference

* adding image as input to create language model object

disable count tokens api for on-device inference (#8962)

VinF Hybrid Inference: throw if only_on_device and model is unavailable (#8965)
gsiddh pushed a commit that referenced this pull request Apr 23, 2025
Fix languageCode parameter in action_code_url (#8912)

* Fix languageCode parameter in action_code_url

* Add changeset

Vaihi add langmodel types. (#8927)

* Adding LanguageModel types. These are based off https://github.com/webmachinelearning/prompt-api?tab=readme-ov-file#full-api-surface-in-web-idl

* Adding LanguageModel types.

* Remove bunch of exports

* yarn formatted

* after lint

Define HybridParams (#8935)

Co-authored-by: Erik Eldridge <[email protected]>

Adding smoke test for new hybrid params (#8937)

* Adding smoke test for new hybrid params

* Use the existing name of the model params input

---------

Co-authored-by: Erik Eldridge <[email protected]>

Moving to in-cloud naming (#8938)

Co-authored-by: Erik Eldridge <[email protected]>

Moving to string type for the inference mode (#8941)

Define ChromeAdapter class (#8942)

Co-authored-by: Erik Eldridge <[email protected]>

VinF Hybrid Inference: Implement ChromeAdapter (rebased) (#8943)

Adding count token impl (#8950)

VinF Hybrid Inference #4: ChromeAdapter in stream methods (rebased) (#8949)

Define values for Availability enum (#8951)

VinF Hybrid Inference: narrow Chrome input type (#8953)

Add image inference support (#8954)

* Adding image based input for inference

* adding image as input to create language model object

disable count tokens api for on-device inference (#8962)

VinF Hybrid Inference: throw if only_on_device and model is unavailable (#8965)
gsiddh pushed a commit that referenced this pull request Apr 23, 2025
Fix languageCode parameter in action_code_url (#8912)

* Fix languageCode parameter in action_code_url

* Add changeset

Vaihi add langmodel types. (#8927)

* Adding LanguageModel types. These are based off https://github.com/webmachinelearning/prompt-api?tab=readme-ov-file#full-api-surface-in-web-idl

* Adding LanguageModel types.

* Remove bunch of exports

* yarn formatted

* after lint

Define HybridParams (#8935)

Co-authored-by: Erik Eldridge <[email protected]>

Adding smoke test for new hybrid params (#8937)

* Adding smoke test for new hybrid params

* Use the existing name of the model params input

---------

Co-authored-by: Erik Eldridge <[email protected]>

Moving to in-cloud naming (#8938)

Co-authored-by: Erik Eldridge <[email protected]>

Moving to string type for the inference mode (#8941)

Define ChromeAdapter class (#8942)

Co-authored-by: Erik Eldridge <[email protected]>

VinF Hybrid Inference: Implement ChromeAdapter (rebased) (#8943)

Adding count token impl (#8950)

VinF Hybrid Inference #4: ChromeAdapter in stream methods (rebased) (#8949)

Define values for Availability enum (#8951)

VinF Hybrid Inference: narrow Chrome input type (#8953)

Add image inference support (#8954)

* Adding image based input for inference

* adding image as input to create language model object

disable count tokens api for on-device inference (#8962)

VinF Hybrid Inference: throw if only_on_device and model is unavailable (#8965)
gsiddh pushed a commit that referenced this pull request May 6, 2025
Fix languageCode parameter in action_code_url (#8912)

* Fix languageCode parameter in action_code_url

* Add changeset

Vaihi add langmodel types. (#8927)

* Adding LanguageModel types. These are based off https://github.com/webmachinelearning/prompt-api?tab=readme-ov-file#full-api-surface-in-web-idl

* Adding LanguageModel types.

* Remove bunch of exports

* yarn formatted

* after lint

Define HybridParams (#8935)

Co-authored-by: Erik Eldridge <[email protected]>

Adding smoke test for new hybrid params (#8937)

* Adding smoke test for new hybrid params

* Use the existing name of the model params input

---------

Co-authored-by: Erik Eldridge <[email protected]>

Moving to in-cloud naming (#8938)

Co-authored-by: Erik Eldridge <[email protected]>

Moving to string type for the inference mode (#8941)

Define ChromeAdapter class (#8942)

Co-authored-by: Erik Eldridge <[email protected]>

VinF Hybrid Inference: Implement ChromeAdapter (rebased) (#8943)

Adding count token impl (#8950)

VinF Hybrid Inference #4: ChromeAdapter in stream methods (rebased) (#8949)

Define values for Availability enum (#8951)

VinF Hybrid Inference: narrow Chrome input type (#8953)

Add image inference support (#8954)

* Adding image based input for inference

* adding image as input to create language model object

disable count tokens api for on-device inference (#8962)

VinF Hybrid Inference: throw if only_on_device and model is unavailable (#8965)

VinF Hybrid Inference: update docs (#8970)

VinF Hybrid Inference: consolidate onDeviceParams initialization (#8969)

VinF Hybrid Inference: disable multi-turn support (#8973)

VinF Hybrid Inference: remove default expected input types (#8974)

VinF Hybrid Inference: set image (and text) as default input type (#8984)

VinF Hybrid Inference: log debug messages in conditional logic (#8992)
gsiddh pushed a commit that referenced this pull request May 13, 2025
---------

Co-authored-by: Erik Eldridge <[email protected]>

Moving to in-cloud naming (#8938)

Co-authored-by: Erik Eldridge <[email protected]>

Moving to string type for the inference mode (#8941)

Define ChromeAdapter class (#8942)

Co-authored-by: Erik Eldridge <[email protected]>

VinF Hybrid Inference: Implement ChromeAdapter (rebased) (#8943)

Adding count token impl (#8950)

VinF Hybrid Inference #4: ChromeAdapter in stream methods (rebased) (#8949)

Define values for Availability enum (#8951)

VinF Hybrid Inference: narrow Chrome input type (#8953)

Add image inference support (#8954)

* Adding image based input for inference

* adding image as input to create language model object

disable count tokens api for on-device inference (#8962)

VinF Hybrid Inference: throw if only_on_device and model is unavailable (#8965)

VinF Hybrid Inference: update docs (#8970)

VinF Hybrid Inference: consolidate onDeviceParams initialization (#8969)

VinF Hybrid Inference: disable multi-turn support (#8973)

VinF Hybrid Inference: remove default expected input types (#8974)

VinF Hybrid Inference: set image (and text) as default input type (#8984)

VinF Hybrid Inference: log debug messages in conditional logic (#8992)

VinF Hybrid Inference: support structured output (#9009)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants