Skip to content

VinF Hybrid Inference: support structured output #9009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 12, 2025

Conversation

erikeldridge
Copy link

@erikeldridge erikeldridge commented May 8, 2025

Problem Statement

VinF and Chrome support structured feedback (VinF, Chrome docs), but we were silently ignoring the configuration to trigger it.

Bug: b/416483422

Solution

Generalize HybridParams to enable creation- and inference-time configuration.

This is consistent with VinF's ModelParams.generationConfig. This doesn't address inference-time configration via the generateContent* methods, but we deprioritized inference-time configration in general for the MVP.

@erikeldridge erikeldridge requested a review from a team as a code owner May 8, 2025 15:30
Copy link

changeset-bot bot commented May 8, 2025

⚠️ No Changeset found

Latest commit: 4c14257

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented May 8, 2025

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v13.0

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 8, 2025

Size Report 1

Affected Products

  • @firebase/vertexai

    TypeBase (e859c03)Merge (a7e9eb4)Diff
    browser46.7 kB46.7 kB-25 B (-0.1%)
    main47.8 kB47.8 kB-25 B (-0.1%)
    module46.7 kB46.7 kB-25 B (-0.1%)
  • firebase

    TypeBase (e859c03)Merge (a7e9eb4)Diff
    firebase-vertexai.js36.8 kB36.8 kB-15 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/mf9hwvHUIs.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 8, 2025

Size Analysis Report 1

Affected Products

  • @firebase/vertexai

    • getGenerativeModel

      Size

      TypeBase (e859c03)Merge (a7e9eb4)Diff
      size26.8 kB26.8 kB-18 B (-0.1%)
      size-with-ext-deps45.9 kB45.8 kB-18 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/aeUL6wpmaE.html

@erikeldridge erikeldridge requested a review from a team as a code owner May 8, 2025 18:36
@erikeldridge erikeldridge merged commit 07c75ea into vaihi-exp-google-ai May 12, 2025
33 of 34 checks passed
@erikeldridge erikeldridge deleted the erikeldridge-vertex-schema branch May 12, 2025 19:50
gsiddh pushed a commit that referenced this pull request May 13, 2025
---------

Co-authored-by: Erik Eldridge <[email protected]>

Moving to in-cloud naming (#8938)

Co-authored-by: Erik Eldridge <[email protected]>

Moving to string type for the inference mode (#8941)

Define ChromeAdapter class (#8942)

Co-authored-by: Erik Eldridge <[email protected]>

VinF Hybrid Inference: Implement ChromeAdapter (rebased) (#8943)

Adding count token impl (#8950)

VinF Hybrid Inference #4: ChromeAdapter in stream methods (rebased) (#8949)

Define values for Availability enum (#8951)

VinF Hybrid Inference: narrow Chrome input type (#8953)

Add image inference support (#8954)

* Adding image based input for inference

* adding image as input to create language model object

disable count tokens api for on-device inference (#8962)

VinF Hybrid Inference: throw if only_on_device and model is unavailable (#8965)

VinF Hybrid Inference: update docs (#8970)

VinF Hybrid Inference: consolidate onDeviceParams initialization (#8969)

VinF Hybrid Inference: disable multi-turn support (#8973)

VinF Hybrid Inference: remove default expected input types (#8974)

VinF Hybrid Inference: set image (and text) as default input type (#8984)

VinF Hybrid Inference: log debug messages in conditional logic (#8992)

VinF Hybrid Inference: support structured output (#9009)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants