Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

[firebase_ml_vision] Add rawBytes to the Barcode class #1816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
the-mars-rover opened this issue Jan 14, 2020 · 4 comments
Closed

[firebase_ml_vision] Add rawBytes to the Barcode class #1816

the-mars-rover opened this issue Jan 14, 2020 · 4 comments
Labels
impact: crowd Affects many people, though not necessarily a specific customer with an assigned label. (P2) plugin: ml_vision type: enhancement New feature or request

Comments

@the-mars-rover
Copy link

the-mars-rover commented Jan 14, 2020 •
edited
Loading

The problem I am facing:
I need to scan barcodes which are in ISO 8859-1 (latin1) format. However, the rawValue property of the Barcode class has already been encoded using UTF-8 and contains some replacement characters (�). Consequently, I am unable to determine what the actual value of the data was.

Proposed Solution:
Add a rawBytes property to the Barcode class - populate this property using getRawBytes on Android and rawData on iOS. Then, in cases that the barcode follows formats other than UTF-8, rawBytes can be used with the applicable format.

Some problems which are similar to this (even though they are on different projects):

If there is a better solution to this problem I really would like some help.
@the-mars-rover the-mars-rover added the type: enhancement New feature or request label Jan 14, 2020
@the-mars-rover the-mars-rover changed the title [firebase_ml_vision] Add rawBytes to the 'Barcode' class [firebase_ml_vision] Add rawBytes to the Barcode class Jan 14, 2020
@the-mars-rover the-mars-rover changed the title [firebase_ml_vision] Add rawBytes to the Barcode class [firebase_ml_vision] Add rawBytes to the Barcode class Jan 14, 2020
the-mars-rover pushed a commit to the-mars-rover/flutterfire that referenced this issue Jan 15, 2020
[firebase_ml_vision] Add rawBytes to the Barcode class (firebase#1816)
cb03bf0
@the-mars-rover the-mars-rover mentioned this issue Jan 15, 2020
Closed
13 tasks
@the-mars-rover the-mars-rover mentioned this issue Mar 16, 2020
Closed
@the-mars-rover the-mars-rover mentioned this issue Apr 15, 2020
Closed
13 tasks
@the-mars-rover
Copy link
Author

Submitted a PR for this: #2368

@Ehesp Ehesp added impact: crowd Affects many people, though not necessarily a specific customer with an assigned label. (P2) plugin: ml_vision labels Apr 21, 2020
Ehesp pushed a commit that referenced this issue Oct 20, 2020
@collinjackson
[firebase_messaging] add integration tests (#1816)
adb1d85 
* Initial firebase_messaging integration tests
@the-mars-rover
Copy link
Author

Updated the linked PR by pulling in latest master

@dayron9110
Copy link

Any updates?

@dayron9110
Copy link

News?

@Salakar Salakar closed this as completed Apr 1, 2021
@firebase firebase locked and limited conversation to collaborators Apr 1, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Assignees
No one assigned
Labels
impact: crowd Affects many people, though not necessarily a specific customer with an assigned label. (P2) plugin: ml_vision type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Ehesp @Salakar @PolinaGo @dayron9110 @the-mars-rover