Skip to content

[firebase_ml_vision] Add rawBytes to the Barcode class (#1816) #1820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

the-mars-rover
Copy link

@the-mars-rover the-mars-rover commented Jan 15, 2020

Description

  • Upgrade of the firebase-ml-vision android dependancy to 24.0.1 to allow access to getRawBytes.
  • In the example, upgraded the firebase-ml-vision-image-label-model and firebase-ml-vision-face-model android dependencies to 19.0.0 to accommodate the aforementioned upgrade of firebase-ml-vision (Without these upgrades version solving will fail).
  • Added rawBytes to the Barcode class. Populated this with getRawBytes for android and with rawData for iOS

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@the-mars-rover
Copy link
Author

@googlebot I fixed it.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Contributor

@collinjackson collinjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@collinjackson
Copy link
Contributor

It's a bit unfortunate that we have to release this as a breaking change. If we landed #39 then we wouldn't have to make this a breaking change.

@the-mars-rover
Copy link
Author

Thanks for the PR! Can we get a unit test for this? See https://github.com/FirebaseExtended/flutterfire/blob/master/packages/firebase_ml_vision/test/firebase_ml_vision_test.dart

Updated the PR by adding rawBytes to some existing unit tests - I believe this will suffice?:)

@the-mars-rover
Copy link
Author

It's a bit unfortunate that we have to release this as a breaking change. If we landed #39 then we wouldn't have to make this a breaking change.

Definitely unfortunate. Will keep an eye on #39 and update this PR accordingly if it lands 💯

@the-mars-rover
Copy link
Author

Solved the merge conflicts

@firebase firebase locked and limited conversation to collaborators Aug 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants