-
Notifications
You must be signed in to change notification settings - Fork 4k
[firebase_ml_vision] Add rawBytes to the Barcode class (#1816) #1820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[firebase_ml_vision] Add rawBytes to the Barcode class (#1816) #1820
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Can we get a unit test for this? See https://github.com/FirebaseExtended/flutterfire/blob/master/packages/firebase_ml_vision/test/firebase_ml_vision_test.dart
It's a bit unfortunate that we have to release this as a breaking change. If we landed #39 then we wouldn't have to make this a breaking change. |
Updated the PR by adding |
Solved the merge conflicts |
Description
firebase-ml-vision
android dependancy to24.0.1
to allow access togetRawBytes
.firebase-ml-vision-image-label-model
andfirebase-ml-vision-face-model
android dependencies to19.0.0
to accommodate the aforementioned upgrade of firebase-ml-vision (Without these upgrades version solving will fail).rawBytes
to theBarcode
class. Populated this withgetRawBytes
for android and withrawData
for iOSRelated Issues
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?