Skip to content

[cloud_firestore] step 2 in landing FieldValue equality comparison (web) #2062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Feb 26, 2020
Merged

[cloud_firestore] step 2 in landing FieldValue equality comparison (web) #2062

merged 25 commits into from
Feb 26, 2020

Conversation

collinjackson
Copy link
Contributor

@collinjackson collinjackson commented Feb 26, 2020 •
edited
Loading

This is part two of a 3-part changes that addresses #2018.

Part one (platform interface) is here: #2060
Part three (app-facing) is here: #2063

This part updates the web implementation to use the new published platform interface.

@collinjackson collinjackson requested a review from ditman February 26, 2020 18:14
@collinjackson collinjackson changed the title Second step in landing the fix for #2018 [cloud_firestore] step 2 in landing FieldValue equality comparison Feb 26, 2020
This was referenced Feb 26, 2020
Merged
Merged
@collinjackson collinjackson changed the title [cloud_firestore] step 2 in landing FieldValue equality comparison [cloud_firestore] step 2 in landing FieldValue equality comparison (wweb) Feb 26, 2020
@collinjackson collinjackson changed the title [cloud_firestore] step 2 in landing FieldValue equality comparison (wweb) [cloud_firestore] step 2 in landing FieldValue equality comparison (web) Feb 26, 2020
@ditman
Copy link
Contributor

ditman commented Feb 26, 2020

The code from platform_interface in this PR is just so tests pass before the changes in 2060 get published?

@collinjackson
Copy link
Contributor Author

The code from platform_interface in this PR is just so tests pass before the changes in 2060 get published?

I think the tests won't pass either way until #2060 lands, but yeah, once I merge #2060 those changes should disappear from this PR.

@collinjackson
Copy link
Contributor Author

The analyzer error is a deprecation warning and will be fixed when I land the changes in part 3.

ditman
ditman approved these changes Feb 26, 2020
View reviewed changes
Copy link
Contributor

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@collinjackson collinjackson merged commit 13540cf into firebase:master Feb 26, 2020
@firebase firebase locked and limited conversation to collaborators Aug 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ditman ditman ditman approved these changes

@mehmetf mehmetf Awaiting requested review from mehmetf

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@collinjackson @ditman @googlebot