Skip to content

[cloud_firestore] step 3 in landing FieldValue equality comparison (app-facing) #2063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Feb 26, 2020

Conversation

collinjackson
Copy link
Contributor

@collinjackson collinjackson commented Feb 26, 2020

This is part three of a 3-part change, split up because federation requires it.

Part one is here: #2060
Part two is here: #2062
Fixes #2018

This part updates the app-facing plugin to use the new published platform interface.

@collinjackson collinjackson changed the title Part 3 of FieldValue equality [cloud_firestore] step 3 in landing FieldValue equality comparison Feb 26, 2020
@collinjackson collinjackson requested a review from ditman February 26, 2020 18:39
@collinjackson collinjackson changed the title [cloud_firestore] step 3 in landing FieldValue equality comparison [cloud_firestore] step 3 in landing FieldValue equality comparison (app-facing) Feb 26, 2020
Copy link
Contributor

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the integ tests!

@collinjackson collinjackson merged commit 44e07cc into firebase:master Feb 26, 2020
@firebase firebase locked and limited conversation to collaborators Aug 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cloud_firestore] FieldValue should support equality comparison
3 participants