-
Notifications
You must be signed in to change notification settings - Fork 4k
[firebase_storage] Add macOS support #2102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[firebase_storage] Add macOS support #2102
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks
@franciscojma86 // @collinjackson thanks for the quick review. Can you merge this? |
Any updates? |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
I just fixed the merge conflicts and added the user agent fix. I forgot that the google bot doesn't like co-authored PRs :( @cbenhagen can you respond with the "I consent" message? If that doesn't work, I think you can just squash my commits and force push |
I think it has to be |
@googlebot I consent |
@googlebot I consent. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Thanks @franciscojma86 |
No worries! Sorry for the delay. Somehow I lost track of this PR :) |
Description
Adds macOS support. Already includes fix proposed in #2099.
/cc @collinjackson @franciscojma86
Related Issues
#1653
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?