Skip to content

[firebase_storage] Add macOS support #2102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 26, 2020

Conversation

cbenhagen
Copy link
Contributor

Description

Adds macOS support. Already includes fix proposed in #2099.

/cc @collinjackson @franciscojma86

Related Issues

#1653

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

Copy link
Contributor

@collinjackson collinjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@cbenhagen
Copy link
Contributor Author

@franciscojma86 // @collinjackson thanks for the quick review. Can you merge this?

@nilsreichardt
Copy link
Contributor

Any updates?

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@franciscojma86
Copy link
Contributor

I just fixed the merge conflicts and added the user agent fix. I forgot that the google bot doesn't like co-authored PRs :( @cbenhagen can you respond with the "I consent" message? If that doesn't work, I think you can just squash my commits and force push

@franciscojma86
Copy link
Contributor

I think it has to be @googlebot I consent.

@cbenhagen
Copy link
Contributor Author

@googlebot I consent

@franciscojma86
Copy link
Contributor

@googlebot I consent.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@franciscojma86 franciscojma86 merged commit bdb95fc into firebase:master Mar 26, 2020
@cbenhagen
Copy link
Contributor Author

Thanks @franciscojma86

@franciscojma86
Copy link
Contributor

No worries! Sorry for the delay. Somehow I lost track of this PR :)

@cbenhagen cbenhagen deleted the firebase_storage_macos branch March 26, 2020 22:38
@firebase firebase locked and limited conversation to collaborators Aug 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants