[all] fix for UserAgent.h compilation failures

[collinjackson]

Right now the development cocoapod is named the same thing on iOS and MacOS. I think this may be why the podspec's prepare_command is not running consistently for both iOS and MacOS.

The attached change points both platforms at a pregenerated shared UserAgent.h, ensuring that it always exists. With this change, the version should always be set but we'll be able to detect if it's not by an "unknown" version showing up as the version on the server side.

Fixes #2087
Fixes #1858
Fixes #2084

[collinjackson]

@franciscojma86 @jmagman while I think this fix will work for now, I'm wondering if Flutter plugins should be using a different pod name for the iOS and Mac development pods.

[jmagman]

#1858 (comment)

Those missing files should be coming from the firebase* podspec prepare_command which only get run when the pod is first downloaded. I don't know how this works when the pod isn't being downloaded via pod but instead via a symlink to the pub-cache...
I was able to reproduce this by adding this to a pubspec:

  firebase_auth: 
  firebase_storage: 
  firebase_core: 

Running flutter pub get then running:

flutter pub cache repair

which deleted the UserAgent.h files.

Essentially: s.prepare_command shouldn't be relied on in a podspec that is distributed via pub.

https://github.com/FirebaseExtended/flutterfire/blob/00c0c8707fcced86faec0d752b6c8bf43b3fcd7c/packages/cloud_firestore/cloud_firestore/ios/cloud_firestore.podspec#L28

Instead of generating a header file to define these macros instead you can use GCC_PREPROCESSOR_DEFINITIONS to define them (I didn't test this, should work in theory)

s.pod_target_xcconfig = { 'GCC_PREPROCESSOR_DEFINITIONS' => '$(inherited) LIBRARY_VERSION=unknown LIBRARY_NAME=flutter-fire-fst' }

See #1858 (comment).

[collinjackson]

Thanks! I'll update the PR.

[googlebot]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[jmagman]

Why are the ipa tests failing?

[franciscojma86]

Those are existing failures :( I believe @collinjackson is looking into those, but we don't think those are related to this PR.

[jmagman]

This change LGTM, assuming @collinjackson is fine with this landing on build errors.
I don't know why @googlebot thinks there are commits from authors who haven't signed the cla...

[collinjackson]

@jmagman @franciscojma86 Thank you both SO much for improving this PR -- this approach is simpler, more reliable, and easy to maintain.

[collinjackson]

I'm not sure if this will fix the Crashlytics CI failure but we should probably land a change similar to flutter/plugins#2592 to remove this file:

https://github.com/FirebaseExtended/flutterfire/blob/master/packages/firebase_crashlytics/example/ios/Runner.xcworkspace/xcshareddata/WorkspaceSettings.xcsettings

I'll open a PR for that now. Hopefully then we can land on green (modulo the CLA issue)

[danysz]

Someone can please fix the CLA of google and merge this issue. Is a huge waiting time this UserAgent.h missing

[cbenhagen]

@danysz while you are waiting you can use this branch by adding entries like the following to your pubspec.yaml for every package you need:

dependency_overrides:
  firebase_core:
    git:
      url: https://github.com/collinjackson/flutterfire
      path: packages/firebase_core/firebase_core
      ref: user_agent_mac

Or you can use a local git checkout where you merge the PRs you are waiting for.

[jmagman]

This PR got messy with multiple usernames and a merge conflict, and it was missing the firebase_crashlytics/pubspec.yaml version bump. Closing in favor of #2169.

[jmagman]

There are still UserAgent headers in firebase_remote_config, firebase_database, firebase_dynamic_links, firebase_messaging, firebase_ml_vision, firebase_analytics, firebase_storage, firebase_performance.

@collinjackson @franciscojma86 is there a follow up PR for them?