Skip to content

Fix for UserAgent.h issues #2169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix for UserAgent.h issues #2169

wants to merge 2 commits into from

Conversation

jmagman
Copy link
Contributor

@jmagman jmagman commented Mar 13, 2020 •
edited
Loading

Identical to #2099 but with the firebase_crashlytics CHANGELOG merge issue and analyzer warnings fixed.

Remove the UserAgent.h header in favor of defining LIBRARY_VERSION and LIBRARY_NAME in the GCC_PREPROCESSOR_DEFINITIONS in the podspec.

Fixes #2087
Fixes #1858
Fixes #2084

@jmagman jmagman requested a review from franciscojma86 March 13, 2020 18:18
@jmagman jmagman mentioned this pull request Mar 13, 2020
Closed
@jmagman
Copy link
Contributor Author

jmagman commented Mar 13, 2020 •
edited
Loading

New analyzer warning for change introduced in #1686. Fixing in this PR.

Checking project cloud_firestore_platform_interface...

  info - Two keys in a map literal shouldn't be equal at test/method_channel_cloud_firestore_test.dart:1031:19 - (equal_keys_in_map)
  info - Two keys in a map literal shouldn't be equal at test/method_channel_cloud_firestore_test.dart:1055:19 - (equal_keys_in_map)

2 issues found; analyzed 42 source files in 14.0s.

I guess the analyzer options aren't pegged to a version in this repo?
\cc @collinjackson

jmagman
jmagman commented Mar 13, 2020
View reviewed changes
...d_firestore/cloud_firestore_platform_interface/test/method_channel_cloud_firestore_test.dart
@@ -1028,7 +1028,6 @@ void main() {
'data': kMockDocumentSnapshotData,
},
},
'source': 'default',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Analyzer warning fix: multiple 'source' keys.

jmagman
jmagman commented Mar 13, 2020
View reviewed changes
...d_firestore/cloud_firestore_platform_interface/test/method_channel_cloud_firestore_test.dart
@@ -1052,7 +1051,6 @@ void main() {
'data': kMockDocumentSnapshotData,
},
},
'source': 'default',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Analyzer warning fix: multiple 'source' keys.

@jmagman
Copy link
Contributor Author

jmagman commented Mar 13, 2020

Manually merged with 4d7b2bd to maintain authorship. Closing.

@jmagman jmagman closed this Mar 13, 2020
@jmagman jmagman deleted the user_agent_mac branch March 13, 2020 19:19
This was referenced Mar 13, 2020
Closed
Closed
Closed
jmagman referenced this pull request Mar 13, 2020
@collinjackson @jmagman
Fix for UserAgent.h issues
4d7b2bd
@Saifallak
Copy link

Saifallak commented Mar 15, 2020 •
edited
Loading

firebase_auth 0.15.5+3 not published yet, can you publish it ? @collinjackson @kroikie @franciscojma86 @jmagman

@awhitford
Copy link
Contributor

Besides firebase_auth, I seem to also still have an issue with firebase_storage:

    /Users/anthony/flutter/.pub-cache/hosted/pub.dartlang.org/firebase_storage-3.1.3/ios/Classes/FLTFirebaseStoragePlugin.m:6:9: fatal error: 'UserAgent.h' file not found
    #import "UserAgent.h"
            ^~~~~~~~~~~~~
    1 error generated.

@mono0926
Copy link
Contributor

@jmagman

Thanks, the build error was fixed 👍
But, after this change, bitcode_strip started failed on iOS project which bitcode enabled.

2020-03-16 02:13:56.970 xcodebuild[26510:54603] [MT] IDEDistribution: -[IDEDistributionLogging _createLoggingBundleAtPath:]: Created bundle at path '/var/folders/6q/wgy6jtp12w5gzgm9lzcglpqw0000gn/T/Runner_2020-03-16_02-13-56.965.xcdistributionlogs'.
error: exportArchive: bitcode_strip failed

Error Domain=IDEFoundationErrorDomain Code=1 "bitcode_strip failed" UserInfo={NSLocalizedDescription=bitcode_strip failed}

@jmagman
Copy link
Contributor Author

jmagman commented Mar 17, 2020

@mono0926 please file a new issue at flutter/flutter and fill out the template so we can take a look.

@ifanchu
Copy link

ifanchu commented Mar 19, 2020

so which version should I use? 0.15.5+2 still seeing same issue.

@DenisBogatirov
Copy link

DenisBogatirov commented Mar 20, 2020 •
edited
Loading

Same UserAgent.h issue on firebase-auth: 0.15.5+2, when 0.15.5+3 will be released?

@Saifallak
Copy link

finally it's released now firebase-auth: 0.15.5+3

@franciscojma86 franciscojma86 mentioned this pull request Mar 23, 2020
Merged
13 tasks
@firebase firebase locked and limited conversation to collaborators Aug 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@franciscojma86 franciscojma86 franciscojma86 approved these changes

@collinjackson collinjackson Awaiting requested review from collinjackson

@kroikie kroikie Awaiting requested review from kroikie

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
9 participants
@jmagman @Saifallak @awhitford @mono0926 @ifanchu @DenisBogatirov @franciscojma86 @googlebot @collinjackson